Fix Windows exported symbol check on binutils 2.43; bump builder API version #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binutils 2.43 added some columns and a header row to the exported symbol list. Update our check accordingly. The new code works with older binutils as well. Signed-off-by: Benjamin Gilbert <bgilbert@cs.cmu.edu>
binutils 2.43 is incompatible with older openslide-bin source releases. We could pin older binutils in the Windows builder container, but that's probably more backward compatibility glue than we want to maintain here. Bump the builder API version so older openslide-bin source releases will fail cleanly. Have bintool accept both API versions, since the new code should work with both. Signed-off-by: Benjamin Gilbert <bgilbert@cs.cmu.edu>
DCO signed off ✔️All commits have been signed off. You have certified to the terms of the Developer Certificate of Origin, version 1.1. In particular, you certify that this contribution has not been developed using information obtained under a non-disclosure agreement or other license terms that forbid you from contributing it under the GNU Lesser General Public License, version 2.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
binutils 2.43 added some columns and a header row to the exported symbol list. Update our check accordingly. The new code works with older binutils as well.
We could pin older binutils in the Windows builder container, but that's probably more backward compatibility glue than we want to maintain here. Bump the builder API version so older openslide-bin source releases will fail cleanly, and have bintool accept both API versions.