Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.17] USHIFT-4522: Add retries on rebasing ostree system #3963

Merged
merged 1 commit into from
Sep 24, 2024
Merged

[release-4.17] USHIFT-4522: Add retries on rebasing ostree system #3963

merged 1 commit into from
Sep 24, 2024

Conversation

ggiguash
Copy link
Contributor

Manual cherry-pick of #3952, only including the ostree rebase part.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 23, 2024 •
edited by openshift-ci bot
Loading

@ggiguash: This pull request references USHIFT-4522 which is a valid jira issue.

In response to this:

Manual cherry-pick of #3952, only including the ostree rebase part.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 23, 2024
@openshift-ci openshift-ci bot requested review from pliurh and pmtk September 23, 2024 16:31
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2024
@ggiguash ggiguash changed the title USHIFT-4522: Add retries on rebasing ostree system [release-4.17] USHIFT-4522: Add retries on rebasing ostree system Sep 23, 2024
@ggiguash
Copy link
Contributor Author

/label backport-risk-assessed
/label cherry-pick-approved
/label jira/valid-bug

@openshift-ci openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Sep 23, 2024
@jerpeter1
Copy link
Member

/lgtm
/staff-eng-approved

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 23, 2024

@fakebanana: Can not set label staff-eng-approved: Must be member in one of these teams: [openshift-patch-managers openshift-staff-engineers]

In response to this:

/lgtm
/label staff-eng-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 23, 2024

@fakebanana: changing LGTM is restricted to collaborators

In response to this:

/lgtm
/label staff-eng-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, jerpeter1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2024
@jerpeter1
Copy link
Member

/label staff-eng-approved

@openshift-ci openshift-ci bot added the staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). label Sep 24, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 24, 2024

@ggiguash: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit a78ac42 into openshift:release-4.17 Sep 24, 2024
8 checks passed
@ggiguash ggiguash deleted the retry_rebase_417 branch September 25, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pliurh pliurh Awaiting requested review from pliurh

@pmtk pmtk Awaiting requested review from pmtk

Assignees

@jerpeter1 jerpeter1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ggiguash @openshift-ci-robot @jerpeter1