Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding stop-replication permission to index_management_full_access #5160

Merged

Conversation

aggarwalShivani
Copy link
Contributor

Description

This change adds an additional permission to index_management_full_access role in config/roles.yml.
This permission is needed to execute the newly added "stop_replication action" added in index-management plugin - opensearch-project/index-management#1198

Issues Resolved

Related to opensearch-project/index-management#726

Is this a backport? If so, please add backport PR # and/or commits #, and remove backport-failed label from the original PR.

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

  • New functionality includes testing
  • New functionality has been documented
  • New Roles/Permissions have a corresponding security dashboards plugin PR
  • API changes companion pull request created
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: aggarwalShivani <shivani.aggarwal@nokia.com>
Copy link

codecov bot commented Mar 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.63%. Comparing base (01dd98c) to head (92e4b67).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5160      +/-   ##
==========================================
- Coverage   71.67%   71.63%   -0.04%     
==========================================
  Files         337      337              
  Lines       22783    22783              
  Branches     3604     3604              
==========================================
- Hits        16329    16321       -8     
- Misses       4653     4660       +7     
- Partials     1801     1802       +1     

see 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@willyborankin willyborankin added the backport 2.x backport to 2.x branch label Mar 10, 2025
@willyborankin willyborankin merged commit 4c5d992 into opensearch-project:main Mar 10, 2025
43 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 10, 2025
…5160)

Signed-off-by: aggarwalShivani <shivani.aggarwal@nokia.com>
(cherry picked from commit 4c5d992)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants