Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces password generator step to a secure password generator action #5153

Conversation

DarshitChanpura
Copy link
Member

@DarshitChanpura DarshitChanpura commented Mar 6, 2025

Current step generates names as password which may not be strong enough for future CI given that we require a strong password now.

Testing

  • CI

Check List

  • New functionality includes testing
  • New functionality has been documented
  • New Roles/Permissions have a corresponding security dashboards plugin PR
  • API changes companion pull request created
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
@DarshitChanpura DarshitChanpura force-pushed the add-random-pass-action branch from ce96fec to be5ce1e Compare March 6, 2025 05:55
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.68%. Comparing base (aa22ca8) to head (5adf416).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5153      +/-   ##
==========================================
- Coverage   71.70%   71.68%   -0.02%     
==========================================
  Files         337      337              
  Lines       22781    22781              
  Branches     3604     3604              
==========================================
- Hits        16334    16330       -4     
- Misses       4646     4651       +5     
+ Partials     1801     1800       -1     

see 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DarshitChanpura DarshitChanpura marked this pull request as ready for review March 6, 2025 06:24
@derek-ho
Copy link
Collaborator

derek-ho commented Mar 6, 2025

As far as I am aware, demo configuration doesn't require a strong password/perform validation with -t flag

@DarshitChanpura DarshitChanpura merged commit 8803690 into opensearch-project:main Mar 6, 2025
42 checks passed
@DarshitChanpura DarshitChanpura added the backport 2.x backport to 2.x branch label Mar 6, 2025
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security/backport-2.x
# Create a new branch
git switch --create backport/backport-5153-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 88036909c46230a3d743f2e7fc9cb71b7ca31594
# Push it to GitHub
git push --set-upstream origin backport/backport-5153-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-5153-to-2.x.

DarshitChanpura added a commit to DarshitChanpura/security that referenced this pull request Mar 6, 2025
opensearch-project#5153)

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
(cherry picked from commit 8803690)
@DarshitChanpura DarshitChanpura deleted the add-random-pass-action branch March 6, 2025 20:22
DarshitChanpura added a commit that referenced this pull request Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch backport-failed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants