-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaces password generator step to a secure password generator action #5153
Replaces password generator step to a secure password generator action #5153
Conversation
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
ce96fec
to
be5ce1e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5153 +/- ##
==========================================
- Coverage 71.70% 71.68% -0.02%
==========================================
Files 337 337
Lines 22781 22781
Branches 3604 3604
==========================================
- Hits 16334 16330 -4
- Misses 4646 4651 +5
+ Partials 1801 1800 -1 🚀 New features to boost your workflow:
|
As far as I am aware, demo configuration doesn't require a strong password/perform validation with -t flag |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security/backport-2.x
# Create a new branch
git switch --create backport/backport-5153-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 88036909c46230a3d743f2e7fc9cb71b7ca31594
# Push it to GitHub
git push --set-upstream origin backport/backport-5153-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security/backport-2.x Then, create a pull request where the |
opensearch-project#5153) Signed-off-by: Darshit Chanpura <dchanp@amazon.com> (cherry picked from commit 8803690)
Current step generates names as password which may not be strong enough for future CI given that we require a strong password now.
Testing
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.