-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TLS configuration settings/endpoints for auxiliary transports #5152
Draft
finnegancarroll
wants to merge
22
commits into
opensearch-project:main
Choose a base branch
from
finnegancarroll:aux-transport
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add TLS configuration settings/endpoints for auxiliary transports #5152
finnegancarroll
wants to merge
22
commits into
opensearch-project:main
from
finnegancarroll:aux-transport
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace hard coded setting prefixes with static constants. Signed-off-by: Finn Carroll <carrofin@amazon.com>
…used in plugin. Signed-off-by: Finn Carroll <carrofin@amazon.com>
…TTP_CRL_FILE. Signed-off-by: Finn Carroll <carrofin@amazon.com>
Signed-off-by: Finn Carroll <carrofin@amazon.com>
Signed-off-by: Finn Carroll <carrofin@amazon.com>
Signed-off-by: Finn Carroll <carrofin@amazon.com>
Signed-off-by: Finn Carroll <carrofin@amazon.com>
Signed-off-by: Finn Carroll <carrofin@amazon.com>
Signed-off-by: Finn Carroll <carrofin@amazon.com>
Signed-off-by: Finn Carroll <carrofin@amazon.com>
Signed-off-by: Finn Carroll <carrofin@amazon.com>
Signed-off-by: Finn Carroll <carrofin@amazon.com>
Signed-off-by: Finn Carroll <carrofin@amazon.com>
…nfigDefine(SECURITY_SSL_HTTP_ENABLED) are the same test. Removing dup. Signed-off-by: Finn Carroll <carrofin@amazon.com>
…generic helper. Add aux and node-to-node transports. Signed-off-by: Finn Carroll <carrofin@amazon.com>
…h generic transport helper. Add aux transport case. Signed-off-by: Finn Carroll <carrofin@amazon.com>
…ing name instead of value. Signed-off-by: Finn Carroll <carrofin@amazon.com>
…h generic helper. Add aux transport case. Signed-off-by: Finn Carroll <carrofin@amazon.com>
Signed-off-by: Finn Carroll <carrofin@amazon.com>
Signed-off-by: Finn Carroll <carrofin@amazon.com>
… easier application to each CertType. Add aux transport cases. Signed-off-by: Finn Carroll <carrofin@amazon.com>
Signed-off-by: Finn Carroll <carrofin@amazon.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5152 +/- ##
==========================================
+ Coverage 71.64% 71.68% +0.04%
==========================================
Files 335 335
Lines 22748 22803 +55
Branches 3599 3607 +8
==========================================
+ Hits 16297 16346 +49
- Misses 4651 4655 +4
- Partials 1800 1802 +2
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add settings for configuring TLS resources for optional auxiliary client/server transports in OpenSearch core which are supplied and registered by plugins.
Auxiliary transport settings/keys/certificates are distinct from http settings as:
Added settings mirror existing http configuration options with exception:
Issues Resolved
#5104
Do these changes introduce new permission(s) to be displayed in the static dropdown on the front-end? If so, please open a draft PR in the security dashboards plugin and link the draft PR here
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.