Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Update PULL_REQUEST_TEMPLATE to include an API spec change in the checklist. (#4533) #4536

Conversation

DarshitChanpura
Copy link
Member

@DarshitChanpura DarshitChanpura commented Jul 9, 2024

Signed-off-by: dblock dblock@amazon.com
(cherry picked from commit 4f3ea97)

Description

Backports #4533 via 4f3ea97
Manual backport was required due to conflicts in the template.

Check List

- [ ] New functionality includes testing
- [ ] New functionality has been documented
- [ ] New Roles/Permissions have a corresponding security dashboards plugin PR
- [ ] API changes companion pull request created

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…cklist. (opensearch-project#4533)

Signed-off-by: dblock <dblock@amazon.com>
(cherry picked from commit 4f3ea97)
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
@DarshitChanpura DarshitChanpura force-pushed the backport/backport-4533-to-2.x branch from 6762513 to 0d6eb80 Compare July 9, 2024 16:16
@willyborankin willyborankin merged commit 6b31b04 into opensearch-project:2.x Jul 9, 2024
73 of 74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants