Skip to content

Commit d5f0cee

Browse files
authored
fix toString on operational metrics (#219)
Signed-off-by: Chenyang Ji <cyji@amazon.com>
1 parent b115fec commit d5f0cee

File tree

2 files changed

+10
-5
lines changed

2 files changed

+10
-5
lines changed

src/main/java/org/opensearch/plugin/insights/core/metrics/OperationalMetric.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,6 @@ public String getDescription() {
3333

3434
@Override
3535
public String toString() {
36-
return String.format(Locale.ROOT, "%s (%s)", name(), description);
36+
return String.format(Locale.ROOT, "%s", name());
3737
}
3838
}

src/test/java/org/opensearch/plugin/insights/core/metrics/OperationalMetricsTests.java

+9-4
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,14 @@ public void testEnumValues() {
2828

2929
public void testToString() {
3030
// Test the toString method
31-
assertEquals(
32-
"LOCAL_INDEX_READER_PARSING_EXCEPTIONS (Number of errors when parsing with LocalIndexReader)",
33-
OperationalMetric.LOCAL_INDEX_READER_PARSING_EXCEPTIONS.toString()
34-
);
31+
assertEquals("LOCAL_INDEX_READER_PARSING_EXCEPTIONS", OperationalMetric.LOCAL_INDEX_READER_PARSING_EXCEPTIONS.toString());
32+
assertEquals("LOCAL_INDEX_EXPORTER_BULK_FAILURES", OperationalMetric.LOCAL_INDEX_EXPORTER_BULK_FAILURES.toString());
33+
assertEquals("LOCAL_INDEX_EXPORTER_DELETE_FAILURES", OperationalMetric.LOCAL_INDEX_EXPORTER_DELETE_FAILURES.toString());
34+
assertEquals("LOCAL_INDEX_EXPORTER_EXCEPTIONS", OperationalMetric.LOCAL_INDEX_EXPORTER_EXCEPTIONS.toString());
35+
assertEquals("INVALID_EXPORTER_TYPE_FAILURES", OperationalMetric.INVALID_EXPORTER_TYPE_FAILURES.toString());
36+
assertEquals("DATA_INGEST_EXCEPTIONS", OperationalMetric.DATA_INGEST_EXCEPTIONS.toString());
37+
assertEquals("QUERY_CATEGORIZE_EXCEPTIONS", OperationalMetric.QUERY_CATEGORIZE_EXCEPTIONS.toString());
38+
assertEquals("EXPORTER_FAIL_TO_CLOSE_EXCEPTION", OperationalMetric.EXPORTER_FAIL_TO_CLOSE_EXCEPTION.toString());
39+
assertEquals("TOP_N_QUERIES_USAGE_COUNT", OperationalMetric.TOP_N_QUERIES_USAGE_COUNT.toString());
3540
}
3641
}

0 commit comments

Comments
 (0)