Skip to content

Commit b115fec

Browse files
authored
Update default .enabled and exporter.type settings (#217)
Signed-off-by: David Zane <davizane@amazon.com>
1 parent 24a8bbc commit b115fec

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -24,13 +24,13 @@ For information about installing plugins, see [Installing plugins](https://opens
2424

2525
### Enabling top N query monitoring
2626

27-
When you install the `query-insights` plugin, top N query monitoring is disabled by default. To enable top N query monitoring, update the dynamic settings for the desired monitoring types. These settings enable the corresponding collectors and aggregators in the running cluster. For example, to enable monitoring top N queries by latency, update the `search.insights.top_queries.latency.enabled` setting:
27+
When you install the `query-insights` plugin, top N query monitoring is enabled by default. To disable top N query monitoring, update the dynamic cluster settings for the desired metric types. For example, to disable monitoring top N queries by latency, update the `search.insights.top_queries.latency.enabled` setting:
2828

2929
```
3030
PUT _cluster/settings
3131
{
3232
"persistent" : {
33-
"search.insights.top_queries.latency.enabled" : true
33+
"search.insights.top_queries.latency.enabled" : false
3434
}
3535
}
3636
```

src/main/java/org/opensearch/plugin/insights/settings/QueryInsightsSettings.java

+4-4
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ public class QueryInsightsSettings {
9595
*/
9696
public static final Setting<Boolean> TOP_N_LATENCY_QUERIES_ENABLED = Setting.boolSetting(
9797
TOP_N_LATENCY_QUERIES_PREFIX + ".enabled",
98-
false,
98+
true,
9999
Setting.Property.Dynamic,
100100
Setting.Property.NodeScope
101101
);
@@ -159,7 +159,7 @@ public class QueryInsightsSettings {
159159
*/
160160
public static final Setting<Boolean> TOP_N_CPU_QUERIES_ENABLED = Setting.boolSetting(
161161
TOP_N_CPU_QUERIES_PREFIX + ".enabled",
162-
false,
162+
true,
163163
Setting.Property.Dynamic,
164164
Setting.Property.NodeScope
165165
);
@@ -189,7 +189,7 @@ public class QueryInsightsSettings {
189189
*/
190190
public static final Setting<Boolean> TOP_N_MEMORY_QUERIES_ENABLED = Setting.boolSetting(
191191
TOP_N_MEMORY_QUERIES_PREFIX + ".enabled",
192-
false,
192+
true,
193193
Setting.Property.Dynamic,
194194
Setting.Property.NodeScope
195195
);
@@ -229,7 +229,7 @@ public class QueryInsightsSettings {
229229
/**
230230
* Default exporter type of top queries
231231
*/
232-
public static final String DEFAULT_TOP_QUERIES_EXPORTER_TYPE = SinkType.NONE.toString();
232+
public static final String DEFAULT_TOP_QUERIES_EXPORTER_TYPE = SinkType.LOCAL_INDEX.toString();
233233
/**
234234
* Default Top N local indices retention period in days
235235
*/

0 commit comments

Comments
 (0)