Remove obsolete compose version specifier #3652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonCW
requested review from
elfisher,
AMoo-Miki,
nknize,
krisfreedain,
peterzhuamazon,
CEHENKLE,
dtaivpp,
kolchfa-aws,
nateynateynate and
natebower
as code owners
|
Hi @SimonCW maybe also leave --- untouched as part of the yml lint check? Thanks. |
|
My bad, I wasn't aware that it breaks linting. Thanks @peterzhuamazon! |
Signed-off-by: Simon Weiß <SimonCW@users.noreply.github.com> Signed-off-by: Simon Weiß <weiss.simon@outlook.com>
Signed-off-by: Simon Weiß <weiss.simon@outlook.com>
Signed-off-by: Simon Weiß <weiss.simon@outlook.com>
peterzhuamazon
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Version specifier for docker compose is obsolete. See: https://docs.docker.com/reference/compose-file/version-and-name/#version-top-level-element-obsolete
I did not remove the version specifier from embedded yml in posts on purpose. I don't think we should change blog articles and it's quite clear that the embedded yml is not a stand-alone compose file. Compare:
project-website/_posts/2024-04-30-A-comprehensive-guide-to-setup-and-connect-self-managed-dashboards-with-Amazon-OpenSearch-domain.md
Line 81 in 45a7358
See this PR to collect changes across opensearch-project repos: opensearch-project/documentation-website#8606