Skipping new nodes which do not have the http property present yet. #985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jaco Smit <jacobuss@amazon.com>
jaco-smit
requested review from
ananzh,
kavilla,
dblock,
VachaShah,
nhtruong,
harshavamsi,
timursaurus and
AMoo-Miki
as code owners
nhtruong
reviewed
Feb 26, 2025
Comment on lines
657
to
658
| t.equal(pool.nodesToHost(nodes, 'http:').length, 1); | ||
| t.equal(pool.nodesToHost(nodes, 'http:')[0].url.host, '127.0.0.1:9200'); |
There was a problem hiding this comment.
Doesn't the test on line 645 already encapsulate these 2 tests?
There was a problem hiding this comment.
I guess it does technically. Will remove these. Thanks!
nhtruong
reviewed
Feb 26, 2025
CHANGELOG.md
Outdated
| @@ -14,6 +14,8 @@ Inspired by [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) | |||
| ## [3.3.0] | |||
| ### Changed | |||
| - Updated API to match the OpenSearch spec from Feb 11, 2025 | |||
| ### Fixed | |||
| - Skip nodes that are not ready ready yet ([#984](https://github.com/opensearch-project/opensearch-js/issues/984)) | |||
There was a problem hiding this comment.
Thanks will fix this :D
nhtruong
approved these changes
Feb 26, 2025
ananzh
approved these changes
Feb 26, 2025
Signed-off-by: Jaco Smit <jacobuss@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New nodes do not necessarily have the
httpproperty present. Skipping these nodes to avoid issues where the property is accessed.Issues Resolved
#984
Check List
yarn run lintdoesn't show any errorsBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.