Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding ad remote index tests #1755

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

adding ad remote index tests #1755

wants to merge 8 commits into from

Conversation

amitgalitz
Copy link
Member

Description

Adding remote detector integration tests for anomaly detection plugin

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@amitgalitz
Copy link
Member Author

One of the tests is failing with failed because it uses a deprecated version of actions/cache: v1. Please update your workflow to use v3/v4 of actions/cache to avoid interruptions should I update the cache version being used in all these workflows or keep as is?

@kaituo
Copy link
Contributor

kaituo commented Mar 18, 2025

Looks good. Will approve once the actions/cache version issue gets answered.

@amitgalitz
adding ad remote index tests
37ac7c7 
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
@kaituo
Copy link
Contributor

kaituo commented Mar 19, 2025

remote cluster tests failed:

Spec Tests Passing Failing Pending Skipped
┌────────────────────────────────────────────────────────────────────────────────────────────────┐
│ ✔ plugins/anomaly-detection-dashboard 00:28 1 1 - - - │
│ s-plugin/create_detector_spec.js │
├────────────────────────────────────────────────────────────────────────────────────────────────┤
│ ✖ plugins/anomaly-detection-dashboard 02:28 2 - 2 - - │
│ s-plugin/create_remote_detector_spe │
│ c.js │
├────────────────────────────────────────────────────────────────────────────────────────────────┤
│ ✔ plugins/anomaly-detection-dashboard 00:34 8 8 - - - │
│ s-plugin/dashboard_spec.js │
├────────────────────────────────────────────────────────────────────────────────────────────────┤
│ ✔ plugins/anomaly-detection-dashboard 00:28 5 5 - - - │
│ s-plugin/detector_configuration_spe │
│ c.js

@amitgalitz
Copy link
Member Author

remote cluster tests failed:

Spec Tests Passing Failing Pending Skipped ┌────────────────────────────────────────────────────────────────────────────────────────────────┐ │ ✔ plugins/anomaly-detection-dashboard 00:28 1 1 - - - │ │ s-plugin/create_detector_spec.js │ ├────────────────────────────────────────────────────────────────────────────────────────────────┤ │ ✖ plugins/anomaly-detection-dashboard 02:28 2 - 2 - - │ │ s-plugin/create_remote_detector_spe │ │ c.js │ ├────────────────────────────────────────────────────────────────────────────────────────────────┤ │ ✔ plugins/anomaly-detection-dashboard 00:34 8 8 - - - │ │ s-plugin/dashboard_spec.js │ ├────────────────────────────────────────────────────────────────────────────────────────────────┤ │ ✔ plugins/anomaly-detection-dashboard 00:28 5 5 - - - │ │ s-plugin/detector_configuration_spe │ │ c.js

Yup I think its cause the remote clusters running on functional test repo aren't named followerCluster, changing it to be dynamic

@amitgalitz
dynamically establish remote cluster name
dbf086e 
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
@kaituo
Copy link
Contributor

kaituo commented Mar 20, 2025

The remote tests still fail:

Spec Tests Passing Failing Pending Skipped
┌────────────────────────────────────────────────────────────────────────────────────────────────┐
│ ✔ plugins/anomaly-detection-dashboard 00:27 1 1 - - - │
│ s-plugin/create_detector_spec.js │
├────────────────────────────────────────────────────────────────────────────────────────────────┤
│ ✖ plugins/anomaly-detection-dashboard 02:28 2 - 2 - - │
│ s-plugin/create_remote_detector_spe │
│ c.js │
├────────────────────────────────────────────────────────────────────────────────────────────────┤
│ ✔ plugins/anomaly-detection-dashboard 00:34 8 8 - - - │
│ s-plugin/dashboard_spec.js │
├──────────────────────────────────────────────────────────────────────

@amitgalitz
update tests to first type in combo box so option is visible
319fdf6 
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
kaituo
kaituo reviewed Mar 20, 2025
View reviewed changes
cypress/integration/plugins/anomaly-detection-dashboards-plugin/create_remote_detector_spec.js Outdated

cy.wait(500);

cy.getElementByTestId('indicesFilter').type('sample-ad-index');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use TEST_INDEX_NAME instead of sample-ad-index ? This applies to all occurrences.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed

@amitgalitz
skip if transport port not set to 9301
51d6e07 
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
@amitgalitz
add transport port dynamically when changing setting
1d9e51c 
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
@amitgalitz
adding transport port to opensearch-start
d59ee5a 
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
@amitgalitz
adding cluster name and changing index selection
601730e 
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
@amitgalitz
remove cluster name
bd72744 
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaituo kaituo kaituo left review comments

@ashwin-pc ashwin-pc ashwin-pc approved these changes

@tianleh tianleh Awaiting requested review from tianleh tianleh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@ohltyler ohltyler Awaiting requested review from ohltyler ohltyler is a code owner

@CCongWang CCongWang Awaiting requested review from CCongWang CCongWang is a code owner

@peterzhuamazon peterzhuamazon Awaiting requested review from peterzhuamazon peterzhuamazon is a code owner

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@prudhvigodithi prudhvigodithi Awaiting requested review from prudhvigodithi prudhvigodithi is a code owner

@xluo-aws xluo-aws Awaiting requested review from xluo-aws xluo-aws is a code owner

@Hailong-am Hailong-am Awaiting requested review from Hailong-am Hailong-am is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@wanglam wanglam Awaiting requested review from wanglam wanglam is a code owner

@raintygao raintygao Awaiting requested review from raintygao raintygao is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@yujin-emma yujin-emma Awaiting requested review from yujin-emma yujin-emma is a code owner

@yubonluo yubonluo Awaiting requested review from yubonluo yubonluo is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amitgalitz @kaituo @ashwin-pc