Add new test suite and workflow for left navigation menu in 2.x #1707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Owen Wang <owenwyk@amazon.com>
Signed-off-by: Owen Wang <owenwyk@amazon.com>
SuZhou-Joe
reviewed
Feb 11, 2025
Comment on lines
+181
to
+189
| if (isWorkspaceEnabled) { | ||
| createWorkspace('all').then(() => { | ||
| cy.visit(`w/${workspaceId}/app/all_overview`); | ||
| validateMenuSection(); | ||
| }); | ||
| } else { | ||
| cy.visit('app/home'); | ||
| validateMenuSection(); | ||
| } |
There was a problem hiding this comment.
Nice section to test both cases.
SuZhou-Joe
reviewed
Feb 11, 2025
...ion/core-opensearch-dashboards/opensearch-dashboards/left-navigation/left_navigation.spec.js
Outdated
Show resolved
Hide resolved
FriedhelmWS
force-pushed
the
left-nav-tests-2.x
branch
5 times, most recently
from
2a51a91 to
386c7f8
Compare
FriedhelmWS
requested review from
tianleh,
kavilla,
ohltyler,
CCongWang,
ashwin-pc,
peterzhuamazon,
ananzh,
prudhvigodithi,
xluo-aws,
Hailong-am,
ruanyl,
wanglam,
raintygao,
zhongnansu,
yujin-emma and
yubonluo
as code owners
SuZhou-Joe
reviewed
Feb 11, 2025
...ion/core-opensearch-dashboards/opensearch-dashboards/left-navigation/left_navigation.spec.js
Outdated
Show resolved
Hide resolved
SuZhou-Joe
reviewed
Feb 11, 2025
...ion/core-opensearch-dashboards/opensearch-dashboards/left-navigation/left_navigation.spec.js
Outdated
Show resolved
Hide resolved
FriedhelmWS
force-pushed
the
left-nav-tests-2.x
branch
from
386c7f8 to
7944564
Compare
SuZhou-Joe
approved these changes
Feb 11, 2025
1 task
FriedhelmWS
force-pushed
the
left-nav-tests-2.x
branch
from
7944564 to
df77f21
Compare
ruanyl
approved these changes
Feb 12, 2025
FriedhelmWS
force-pushed
the
left-nav-tests-2.x
branch
6 times, most recently
from
742d731 to
0c82255
Compare
Signed-off-by: Owen Wang <owenwyk@amazon.com>
FriedhelmWS
force-pushed
the
left-nav-tests-2.x
branch
from
0c82255 to
ba9e106
Compare
Signed-off-by: Owen Wang <owenwyk@amazon.com>
FriedhelmWS
force-pushed
the
left-nav-tests-2.x
branch
from
5cae40e to
1686503
Compare
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-main main
# Navigate to the new working tree
cd .worktrees/backport-main
# Create a new branch
git switch --create backport/backport-1707-to-main
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 947aaa0ba49539b249c4a8f39a45e35c37b780bc
# Push it to GitHub
git push --set-upstream origin backport/backport-1707-to-main
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-mainThen, create a pull request where the |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 12, 2025
* Add new test suite and workflow for left navigation menu Signed-off-by: Owen Wang <owenwyk@amazon.com> * Fix missing config for disable workspace Signed-off-by: Owen Wang <owenwyk@amazon.com> * Address comments by adding additional assertion to navigation menu Signed-off-by: Owen Wang <owenwyk@amazon.com> * Fix lint issue in dashboards test cases Signed-off-by: Owen Wang <owenwyk@amazon.com> --------- Signed-off-by: Owen Wang <owenwyk@amazon.com> (cherry picked from commit 947aaa0)
FriedhelmWS
added a commit
to FriedhelmWS/opensearch-dashboards-functional-test
that referenced
this pull request
Feb 12, 2025
…search-project#1707) * Add new test suite and workflow for left navigation menu Signed-off-by: Owen Wang <owenwyk@amazon.com> * Fix missing config for disable workspace Signed-off-by: Owen Wang <owenwyk@amazon.com> * Address comments by adding additional assertion to navigation menu Signed-off-by: Owen Wang <owenwyk@amazon.com> * Fix lint issue in dashboards test cases Signed-off-by: Owen Wang <owenwyk@amazon.com> --------- Signed-off-by: Owen Wang <owenwyk@amazon.com> (cherry picked from commit 947aaa0)
1 task
raintygao
pushed a commit
that referenced
this pull request
Feb 17, 2025
…enu (#1710) * Add new test suite and workflow for left navigation menu Signed-off-by: Owen Wang <owenwyk@amazon.com> * Fix missing config for disable workspace Signed-off-by: Owen Wang <owenwyk@amazon.com> * Remove tenancy config for left navigation workflow Signed-off-by: Owen Wang <owenwyk@amazon.com> * Address comments by adding additional assertion to navigation menu Signed-off-by: Owen Wang <owenwyk@amazon.com> * Add new test suite and workflow for left navigation menu in 2.x (#1707) * Add new test suite and workflow for left navigation menu Signed-off-by: Owen Wang <owenwyk@amazon.com> * Fix missing config for disable workspace Signed-off-by: Owen Wang <owenwyk@amazon.com> * Address comments by adding additional assertion to navigation menu Signed-off-by: Owen Wang <owenwyk@amazon.com> * Fix lint issue in dashboards test cases Signed-off-by: Owen Wang <owenwyk@amazon.com> --------- Signed-off-by: Owen Wang <owenwyk@amazon.com> (cherry picked from commit 947aaa0) --------- Signed-off-by: Owen Wang <owenwyk@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding specific tests for new left navigation menu, including scenarios with workspace enabled or disabled and enable or disable security.
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.