Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboard query insights dashboards onto functional test repo #1689

Merged

Conversation

ansjcy
Copy link
Member

@ansjcy ansjcy commented Feb 3, 2025

Description

Onboard query insights dashboards onto functional test repo

Issues Resolved

Closes opensearch-project/query-insights-dashboards#101

Check List

  • Commits are signed per the DCO using --signoff

Tests

  • With Security
env CYPRESS_NO_COMMAND_LOG=0 yarn cypress:run-with-security --browser electron --spec 'cypress/integration/plugins/query-insights-dashboards/*'

Query Insights Dashboard
    ✓ should display the main overview page (31737ms)
    ✓ should switch between tabs (24294ms)
    ✓ should filter queries (23158ms)
    ✓ should clear the search input and reset results (18852ms)
    ✓ should display a message when no top queries are found (32845ms)


  5 passing (2m)

...
 Top Queries Details Page
    ✓ should display correct details on the query details page (41020ms)
    ✓ the summary panel should display correctly (33117ms)
    ✓ should display correct values for all fields in the summary panel (31487ms)
    ✓ should render the latency chart and allow interaction (31827ms)


  4 passing (2m)
...

Running:  plugins/query-insights-dashboards/3_configurations.cy.js                        (3 of 3)


  Query Insights Configurations Page
    ✓ should display the Configuration page with correct structure (15429ms)
    ✓ should display 3 metrics in the metric type drop down (6457ms)
    ✓ should allow selecting a metric type (5290ms)
    ✓ should allow enabling and disabling metrics (6318ms)
    ✓ should allow updating the value of N (count) (10658ms)
    ✓ should allow selecting a window size and unit (7535ms)
    ✓ should display statuses for configuration metrics
    ✓ should display settings for configuration metrics for group by
    ✓ should display 2 metrics in the group by drop-down
    ✓ should display configuration statuses for group by metrics
    ✓ should allow saving the configuration (13767ms)


  11 passing (1m)
...


  (Run Finished)


       Spec                                              Tests  Passing  Failing  Pending  Skipped
  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ ✔  plugins/query-insights-dashboards/1      02:11        5        5        -        -        - │
  │    _top_queries.cy.js                                                                          │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  plugins/query-insights-dashboards/2      02:18        4        4        -        -        - │
  │    _query_details.cy.js                                                                        │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  plugins/query-insights-dashboards/3      01:21       11       11        -        -        - │
  │    _configurations.cy.js                                                                       │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘
    ✔  All specs passed!                        05:51       20       20        -        -        -

✨  Done in 418.06s.
  • Without security
 env CYPRESS_NO_COMMAND_LOG=0 yarn cypress:run-without-security --browser electron --spec 'cypress/integration/plugins/query-insights-dashboards/*'
...
Query Insights Dashboard
    ✓ should display the main overview page (27362ms)
    ✓ should switch between tabs (19482ms)
    ✓ should filter queries (16710ms)
    ✓ should clear the search input and reset results (16716ms)
    ✓ should display a message when no top queries are found (28113ms)


  5 passing (2m)
...

 Top Queries Details Page
    ✓ should display correct details on the query details page (37530ms)
    ✓ the summary panel should display correctly (28754ms)
    ✓ should display correct values for all fields in the summary panel (27685ms)
    ✓ should render the latency chart and allow interaction (27548ms)


  4 passing (2m)
...

 Query Insights Configurations Page
    ✓ should display the Configuration page with correct structure (12813ms)
    ✓ should display 3 metrics in the metric type drop down
    ✓ should allow selecting a metric type
    ✓ should allow enabling and disabling metrics
    ✓ should allow updating the value of N (count) (6767ms)
    ✓ should allow selecting a window size and unit (6311ms)
    ✓ should display statuses for configuration metrics
    ✓ should display settings for configuration metrics for group by
    ✓ should display 2 metrics in the group by drop-down
    ✓ should display configuration statuses for group by metrics
    ✓ should allow saving the configuration (12458ms)


  11 passing (59s)
...

 (Run Finished)


       Spec                                              Tests  Passing  Failing  Pending  Skipped
  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ ✔  plugins/query-insights-dashboards/1      01:48        5        5        -        -        - │
  │    _top_queries.cy.js                                                                          │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  plugins/query-insights-dashboards/2      02:01        4        4        -        -        - │
  │    _query_details.cy.js                                                                        │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  plugins/query-insights-dashboards/3      00:58       11       11        -        -        - │
  │    _configurations.cy.js                                                                       │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘
    ✔  All specs passed!                        04:49       20       20        -        -        -

✨  Done in 338.59s.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ansjcy ansjcy changed the title Onboard query insights dashboards onto functional test repo [WIP] Onboard query insights dashboards onto functional test repo Feb 3, 2025
@ansjcy ansjcy force-pushed the onboard-functional-test-repo branch 3 times, most recently from 373b18f to ea616e2 Compare February 4, 2025 22:10
Signed-off-by: Chenyang Ji <cyji@amazon.com>
@ansjcy ansjcy force-pushed the onboard-functional-test-repo branch from ea616e2 to 83608ce Compare February 4, 2025 22:15
@ansjcy ansjcy changed the title [WIP] Onboard query insights dashboards onto functional test repo Onboard query insights dashboards onto functional test repo Feb 4, 2025
@peterzhuamazon
Copy link
Member

Approved based on the author provided log passing.

Thanks.

@peterzhuamazon peterzhuamazon merged commit 578cc7c into opensearch-project:main Feb 4, 2025
44 of 45 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1689-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 578cc7c521b0f7883d83bbb5b7870353ab71faa5
# Push it to GitHub
git push --set-upstream origin backport/backport-1689-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1689-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.19 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.19 2.19
# Navigate to the new working tree
cd .worktrees/backport-2.19
# Create a new branch
git switch --create backport/backport-1689-to-2.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 578cc7c521b0f7883d83bbb5b7870353ab71faa5
# Push it to GitHub
git push --set-upstream origin backport/backport-1689-to-2.19
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.19

Then, create a pull request where the base branch is 2.19 and the compare/head branch is backport/backport-1689-to-2.19.

peterzhuamazon pushed a commit that referenced this pull request Feb 4, 2025
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 4, 2025
…1691)

Signed-off-by: Chenyang Ji <cyji@amazon.com>
(cherry picked from commit 028e8d8)
peterzhuamazon pushed a commit that referenced this pull request Feb 4, 2025
…1691) (#1692)

Signed-off-by: Chenyang Ji <cyji@amazon.com>
(cherry picked from commit 028e8d8)

Co-authored-by: Chenyang Ji <chenyang.yale@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Onboard to functional-test repo
2 participants