feat: Setup workspace workflow file. #1145
Conversation
Signed-off-by: yubonluo <yubonluo@amazon.com>
yubonluo
requested review from
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam and
raintygao
as code owners
| uses: ./.github/workflows/release-e2e-workflow-template.yml | ||
| with: | ||
| test-name: dashboards workspace | ||
| test-command: env CYPRESS_DASHBOARDS_WORKSPACE_ENABLED=true yarn cypress:run-with-security --browser chromium --spec 'cypress/integration/plugins/dashboards-workspace/*' |
There was a problem hiding this comment.
should be cypress:run-without-security?
There was a problem hiding this comment.
Yes, I will correct it.
| with: | ||
| test-name: dashboards workspace | ||
| test-command: env CYPRESS_DASHBOARDS_WORKSPACE_ENABLED=true yarn cypress:run-with-security --browser chromium --spec 'cypress/integration/plugins/dashboards-workspace/*' | ||
| osd-serve-args: --workspace.enabled=true --savedObjects.permission.enabled=true |
There was a problem hiding this comment.
--savedObjects.permission.enabled=false for without security case
There was a problem hiding this comment.
I will correct it.
There was a problem hiding this comment.
Should we move this file to cypress/integration/core-opensearch-dashboards/opensearch-dashboards as workspace is a plugin in core repo.
There was a problem hiding this comment.
Yes, I will move the integration test file to cypress/integration/core-opensearch-dashboards/opensearch-dashboards.
cypress.json
Outdated
| @@ -21,6 +21,7 @@ | |||
| "DATASOURCE_MANAGEMENT_ENABLED": false, | |||
| "ML_COMMONS_DASHBOARDS_ENABLED": true, | |||
| "WAIT_FOR_LOADER_BUFFER_MS": 0, | |||
| "DASHBOARDS_ASSISTANT_ENABLED": false | |||
| "DASHBOARDS_ASSISTANT_ENABLED": false, | |||
| "DASHBOARDS_WORKSPACE_ENABLED": false | |||
There was a problem hiding this comment.
Shall we need start with DASHBOARDS? I think workspace is not direct related dashboard.
There was a problem hiding this comment.
Sure, I will delete the prefix DASHBOARDS .
Signed-off-by: yubonluo <yubonluo@amazon.com>
| with: | ||
| filters: | | ||
| tests: | ||
| - 'cypress/**/dashboards-workspace/**' |
There was a problem hiding this comment.
The test pattern should match cypress/integration/core-opensearch-dashboards/opensearch-dashboards/workspace-plugin I think?
There was a problem hiding this comment.
yes, I will fix the filters.
Signed-off-by: yubonluo <yubonluo@amazon.com>
* feat: enable workspace plugin setup Signed-off-by: yubonluo <yubonluo@amazon.com> * feat: fix some details Signed-off-by: yubonluo <yubonluo@amazon.com> * feat: fix file filters Signed-off-by: yubonluo <yubonluo@amazon.com> --------- Signed-off-by: yubonluo <yubonluo@amazon.com> (cherry picked from commit 736a788)
* feat: enable workspace plugin setup Signed-off-by: yubonluo <yubonluo@amazon.com> * feat: fix some details Signed-off-by: yubonluo <yubonluo@amazon.com> * feat: fix file filters Signed-off-by: yubonluo <yubonluo@amazon.com> --------- Signed-off-by: yubonluo <yubonluo@amazon.com> (cherry picked from commit 736a788)
* feat: enable workspace plugin setup Signed-off-by: yubonluo <yubonluo@amazon.com> * feat: fix some details Signed-off-by: yubonluo <yubonluo@amazon.com> * feat: fix file filters Signed-off-by: yubonluo <yubonluo@amazon.com> --------- Signed-off-by: yubonluo <yubonluo@amazon.com> (cherry picked from commit 736a788) Co-authored-by: yuboluo <15242088755@163.com>
Description
We are going to onboard a new dashboards plugin dashboards-workspace to FTRepo, this is the initial PR to setup basic workflow file. Test cases will be included in following PRs.
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.