Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assistant failed cases because of change of ml-commons #1109

Closed
wants to merge 10 commits into from
Prev Previous commit
Next Next commit
Increase delay times in gantt charts (#1090)
* increase delay times in gantt charts

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
(cherry picked from commit 508fd25)

* update create button text

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* revert create button change

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

---------

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
ps48 authored Feb 16, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 87681ef0632aade537271d795af2810af1a4dd6e
Original file line number Diff line number Diff line change
@@ -11,7 +11,7 @@ import { BASE_PATH } from '../../../utils/constants';

dayjs.extend(customParseFormat);

const delay = 100;
const delay = 5000;
const GANTT_VIS_NAME =
'A test gantt chart ' + Math.random().toString(36).substring(2);
const Y_LABEL = 'A unique label for Y-axis';
@@ -57,6 +57,7 @@ describe('Dump test data', () => {
describe('Save a gantt chart', () => {
beforeEach(() => {
cy.visit(`${BASE_PATH}/app/visualize#`);
cy.wait(delay);
});

it('Creates and saves a gantt chart', () => {
@@ -83,8 +84,10 @@ describe('Save a gantt chart', () => {

describe('Render and configure a gantt chart', () => {
beforeEach(() => {
cy.wait(delay);
cy.visit(`${BASE_PATH}/app/visualize#`);
cy.contains(GANTT_VIS_NAME).click({ force: true });
cy.wait(delay);
});

it('Renders no data message', () => {
@@ -114,7 +117,7 @@ describe('Render and configure a gantt chart', () => {
cy.wait(delay);

cy.get('.traces').should('have.length', DEFAULT_SIZE);

cy.wait(delay);
cy.get('.euiButton__text').contains('Save').click({ force: true });
cy.wait(delay);
cy.get('button[data-test-subj="confirmSaveSavedObjectButton"]').click({
@@ -128,6 +131,7 @@ describe('Configure panel settings', () => {
cy.visit(`${BASE_PATH}/app/visualize#`);
cy.contains(GANTT_VIS_NAME).click({ force: true });
cy.contains('Panel settings').click({ force: true });
cy.wait(delay);
});

it('Changes y-axis label', () => {
@@ -244,7 +248,7 @@ describe('Configure panel settings', () => {
describe('Add gantt chart to dashboard', () => {
it('Adds gantt chart to dashboard', () => {
cy.visit(`${BASE_PATH}/app/dashboards#/create`);

cy.wait(delay);
cy.contains('Add an existing').click({ force: true });
cy.wait(delay);
cy.get('input[data-test-subj="savedObjectFinderSearchInput"]')