-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalize query workbench constant newlines #1105
Normalize query workbench constant newlines #1105
Conversation
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
This reverts commit f25a99f. Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Need backport main or 2.x? |
* Normalize string newlines Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Revert "Normalize string newlines" This reverts commit f25a99f. Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix which side is newline-normalized Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com> (cherry picked from commit 842fe0c)
* Normalize string newlines Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Revert "Normalize string newlines" This reverts commit f25a99f. Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix which side is newline-normalized Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com> (cherry picked from commit 842fe0c)
Just saw it was already merged and backported, thanks 👍 |
* Normalize string newlines Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Revert "Normalize string newlines" This reverts commit f25a99f. Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix which side is newline-normalized Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com> (cherry picked from commit 842fe0c) Co-authored-by: Simeon Widdis <sawiddis@amazon.com>
* Normalize string newlines Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Revert "Normalize string newlines" This reverts commit f25a99f. Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix which side is newline-normalized Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com> (cherry picked from commit 842fe0c) Co-authored-by: Simeon Widdis <sawiddis@amazon.com>
@wanglam @SuZhou-Joe Can we please backport this change to |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.3 1.3
# Navigate to the new working tree
cd .worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-1105-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 842fe0ccc120b79337642c6c4c762453b8ec838d
# Push it to GitHub
git push --set-upstream origin backport/backport-1105-to-1.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.3 Then, create a pull request where the |
Description
When running integration tests on windows, the CSV data inconsistently was encoded with
\r\n
or\n
, which caused a failing test assertion. This PR adds a method to normalize the test data.Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.