Fix index pattern without time field tests #1054
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wanglam
requested review from
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl and
raintygao
as code owners
ruanyl
reviewed
Feb 6, 2024
| @@ -33,6 +33,6 @@ jobs: | |||
| uses: ./.github/workflows/release-e2e-workflow-template.yml | |||
| with: | |||
| test-name: Core Dashboards using Bundle Snapshot | |||
| test-command: env CYPRESS_ML_COMMONS_DASHBOARDS_ENABLED=true CYPRESS_VISBUILDER_ENABLED=true CYPRESS_DATASOURCE_MANAGEMENT_ENABLED=true yarn cypress:run-without-security --browser chromium --spec 'cypress/integration/core-opensearch-dashboards/opensearch-dashboards/**/*.js' | |||
| test-command: env CYPRESS_NO_COMMAND_LOG=1 CYPRESS_ML_COMMONS_DASHBOARDS_ENABLED=true CYPRESS_VISBUILDER_ENABLED=true CYPRESS_DATASOURCE_MANAGEMENT_ENABLED=true yarn cypress:run-without-security --browser chromium --spec 'cypress/integration/core-opensearch-dashboards/opensearch-dashboards/**/*.js' | |||
There was a problem hiding this comment.
Did you include this change to this PR intentionally? Seems not related to this PR
There was a problem hiding this comment.
Yeah, just bypass the pending issue. The workflow will always pending without this env variable.
Signed-off-by: Lin Wang <wonglam@amazon.com>
wanglam
force-pushed
the
fix-index-pattern-without-time-field-failed
branch
from
d620302 to
376b195
Compare
raintygao
approved these changes
Feb 18, 2024
Hailong-am
approved these changes
Feb 19, 2024
|
@wanglam could you help to resolve the conflicts? |
|
The functional tests were successful in current main branch. Here are the job details: https://github.com/opensearch-project/opensearch-dashboards-functional-test/actions/runs/8828305033?pr=999 . I think we don't need to change the test cases anymore. I will close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix index pattern without time field tests failed when security enabled, this test was failed in main branch, see screenshot:
These tests can be passed in the workflow, here is the screenshot:
Also add
CYPRESS_NO_COMMAND_LOGto the workflow file, unhang OSD Core workflows to bypass #1055Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.