-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change tj-actions/changed-files usage from sha to latest version #5402
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5402 +/- ##
=======================================
Coverage 91.98% 91.98%
=======================================
Files 202 202
Lines 7052 7052
=======================================
Hits 6487 6487
Misses 565 565 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use the commit SHA for the change and not label. Using a label is against best practices and had a label been in use the project would have been affected by the compromise of this very action that recently happened.
Signed-off-by: Divya Madala <divyaasm@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I'm not a maintainer, so while this is correct. I won't give the final approval here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like you are not updated to the latest commit?
Which one did you use here?
https://github.com/tj-actions/changed-files/commits/main/
Thanks.
Used the one in the latest version, not main |
Description
Change tj-actions/changed-files usage from sha to latest version
Issues Resolved
Closes #5400
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.