Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change tj-actions/changed-files usage from sha to latest version #5402

Merged
merged 1 commit into from
Mar 17, 2025

Conversation

Divyaasm
Copy link
Collaborator

@Divyaasm Divyaasm commented Mar 17, 2025

Description

Change tj-actions/changed-files usage from sha to latest version

Issues Resolved

Closes #5400

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.98%. Comparing base (b82e71f) to head (3652166).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5402   +/-   ##
=======================================
  Coverage   91.98%   91.98%           
=======================================
  Files         202      202           
  Lines        7052     7052           
=======================================
  Hits         6487     6487           
  Misses        565      565           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

tykeal
tykeal previously requested changes Mar 17, 2025
Copy link

@tykeal tykeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the commit SHA for the change and not label. Using a label is against best practices and had a label been in use the project would have been affected by the compromise of this very action that recently happened.

Signed-off-by: Divya Madala <divyaasm@amazon.com>
Copy link

@tykeal tykeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I'm not a maintainer, so while this is correct. I won't give the final approval here.

@tykeal tykeal dismissed their stale review March 17, 2025 22:38

Resolved in newer revision

Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like you are not updated to the latest commit?
Which one did you use here?
https://github.com/tj-actions/changed-files/commits/main/

Thanks.

@Divyaasm
Copy link
Collaborator Author

Seems like you are not updated to the latest commit? Which one did you use here? https://github.com/tj-actions/changed-files/commits/main/

Thanks.

Used the one in the latest version, not main

@Divyaasm Divyaasm merged commit b45310d into opensearch-project:main Mar 17, 2025
15 checks passed
@Divyaasm Divyaasm deleted the tjactions branch March 18, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[Enhancement] Remove tj-actions/changed-files from the workflows
3 participants