Update binaryspec for deb creation as debmake=4.3.2-1 and above introduced nodejs #5401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterzhuamazon
requested review from
gaiksaya,
rishabh6788,
zelinh,
prudhvigodithi,
Divyaasm and
tianleh
as code owners
66 tasks
peterzhuamazon
changed the title
…duced nodejs Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
peterzhuamazon
force-pushed
the
debmake-binaryspec-updates
branch
from
98237d7 to
1ab812f
Compare
getsaurabh02
approved these changes
Mar 16, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5401 +/- ##
=======================================
Coverage 91.98% 91.98%
=======================================
Files 202 202
Lines 7052 7052
=======================================
Hits 6487 6487
Misses 565 565 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update binaryspec for deb creation as debmake=4.3.2-1 and above introduced nodejs
Note that with dh_installsystemd/13.14.1ubuntu5 the postrm script will auto add which is nice.
Issues Resolved
#3747
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.