Add opensearch-remote-metadata-sdk to manifest #5228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Widdis <widdis@gmail.com>
dbwiddis
requested review from
dblock,
peterzhuamazon,
gaiksaya,
rishabh6788,
zelinh,
prudhvigodithi,
Divyaasm and
tianleh
as code owners
gaiksaya
approved these changes
Jan 13, 2025
|
@dbwiddis Looks like versioning is the issue: Its missing the 4th digit. |
Yeah, I intentionally left that off since I didn't expect to need it (we're not a plugin). But I guess I need to add it back in. |
Should be fixed now if you want to rerun the test. |
It went through for remote-sdk: Issue with reporting plugin. Unrelated to this PR. Proceeding with the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the opensearch-remote-metadata-sdk library to the manifest.
This PR is step 6 of this checklist: https://github.com/opensearch-project/opensearch-build/blob/main/ONBOARDING.md#onboard-to-build-workflow
Note that this is not a plugin. It is a library to be used by plugins in order to refactor common code to a single location. It is similar to
common-utilsin that respect and I attempted to follow that pattern (plain jar rather than zip).PR implementing the build script:
Artifacts published:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.