Ensuring cleanup with OSD plugins when failed during continue-on-error

[peterzhuamazon]

Description

Ensuring cleanup with OSD plugins when failed during continue-on-error

This should be a better solution than adding --single-version loose parameter.

Issues Resolved

opensearch-project/OpenSearch-Dashboards#5675

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4284e27) 91.35% compared to head (2bd07e4) 91.35%.
Report is 4 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4343   +/-   ##
=======================================
  Coverage   91.35%   91.35%           
=======================================
  Files         190      190           
  Lines        6175     6175           
=======================================
  Hits         5641     5641           
  Misses        534      534           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[prudhvigodithi]

This would be definitely a better solution for build system rather than adding --single-version loose parameter., but for a user who is not using the build system and building the OSD with plugins its easy to use --single-version loose parameter. with yarn cli (including in GH runners), I think having both should be good.
Adding @AMoo-Miki @bbarani @gaiksaya

[peterzhuamazon]

This would be definitely a better solution for build system rather than adding --single-version loose parameter., but for a user who is not using the build system and building the OSD with plugins its easy to use --single-version loose parameter. with yarn cli (including in GH runners), I think having both should be good. Adding @AMoo-Miki @bbarani @gaiksaya

So @prudhvigodithi you think we can add both --single-version loose and this new cleanup section together?

Thanks.

[prudhvigodithi]

So @prudhvigodithi you think we can add both --single-version loose and this new cleanup section together?

Thanks.

If we have this PR merged then in the build code or in component build scripts we dont have to add --single-version loose and will continue to work as the clean up is happening now, but for a person who is building OSD or its plugins outside of this build code still can leverage --single-version loose.

[gaiksaya]

So @prudhvigodithi you think we can add both --single-version loose and this new cleanup section together?
Thanks.

If we have this PR merged then in the build code or in component build scripts we dont have to add --single-version loose and will continue to work as the clean up is happening now, but for a person who is building OSD or its plugins outside of this build code still can leverage --single-version loose.

I don't think we need to take that into consideration right? We can add --single-version loose for opensearch-build. For any external build, they need to fix their CI/plugin code to accommodate this.

[peterzhuamazon]

So @prudhvigodithi you think we can add both --single-version loose and this new cleanup section together?
Thanks.

If we have this PR merged then in the build code or in component build scripts we dont have to add --single-version loose and will continue to work as the clean up is happening now, but for a person who is building OSD or its plugins outside of this build code still can leverage --single-version loose.

I don't think we need to take that into consideration right? We can add --single-version loose for opensearch-build. For any external build, they need to fix their CI/plugin code to accommodate this.

That is my thought as well. On our side, if we cleanup properly even with strict mode it will still goes through. If other users want to use the param on their side, that is on them. We can, of course, support this addition as part of the build workflow tho, but not necessary.

I will open an issue to make that as an improvement.

• [Enhancement] Adding support for --single-version loose as part of build_workflow #4345

[peterzhuamazon]

After discussing with @prudhvigodithi @gaiksaya we will continue to work on other plugin build scripts with the same changes

Thanks.

[peterzhuamazon]

After talk with @prudhvigodithi , we will add --single-version loose to other workflows such as github actions in issue #4345 afterwards.