Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Remove tj-actions/changed-files from the workflows #5400

Closed
peterzhuamazon opened this issue Mar 16, 2025 · 5 comments · Fixed by #5402
Closed

[Enhancement] Remove tj-actions/changed-files from the workflows #5400

peterzhuamazon opened this issue Mar 16, 2025 · 5 comments · Fixed by #5402
Assignees
Labels
enhancement New Enhancement

Comments

@peterzhuamazon
Copy link
Member

peterzhuamazon commented Mar 16, 2025

Apparently tj-actions/changed-files has been compromised:
https://www.stepsecurity.io/blog/harden-runner-detection-tj-actions-changed-files-action-is-compromised
opensearch-project/OpenSearch#17597

I realized that in our repo has set this to a specific commit, so no issues for us now.
#5129

Based on the original report very likely we are also affected: Most versions of tj-actions/changed-files are compromised.

However, we do need to think about moving it out.
Thanks.

@peterzhuamazon peterzhuamazon added the enhancement New Enhancement label Mar 16, 2025
@github-actions github-actions bot added the untriaged Issues that have not yet been triaged label Mar 16, 2025
@peterzhuamazon
Copy link
Member Author

Seem like it is just changing tags to point to this commit tj-actions/changed-files@0e58ed8.

And since we already lock to a commit a while ago I think we are fine for now.

Thanks.

@peterzhuamazon
Copy link
Member Author

Seems resolved: tj-actions/changed-files#2464 (comment)

@gaiksaya
Copy link
Member

@Divyaasm Can you please take care of upgrading to recent/fixed version accordingly?
Thanks!

@gaiksaya gaiksaya removed the untriaged Issues that have not yet been triaged label Mar 17, 2025
@Divyaasm
Copy link
Collaborator

@Divyaasm Can you please take care of upgrading to recent/fixed version accordingly? Thanks!

Sure @gaiksaya , Acknowledged!

@gaiksaya
Copy link
Member

Thank you! Assigning it to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New Enhancement
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants