Refactor code to use TemplateProcessor for all templates #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaiksaya
requested review from
peterzhuamazon,
prudhvigodithi,
rishabh6788,
Divyaasm and
zelinh
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #632 +/- ##
=========================================
Coverage 89.04% 89.04%
Complexity 118 118
=========================================
Files 118 118
Lines 575 575
Branches 32 32
=========================================
Hits 512 512
Misses 31 31
Partials 32 32 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
gaiksaya
force-pushed
the
accomodate-templateProcessor
branch
from
e1540e8 to
f3dcdc3
Compare
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
gaiksaya
changed the title
rishabh6788
approved these changes
Mar 25, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 25, 2025
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> (cherry picked from commit 3b6b899) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#631 adds TemplateProcessor for easy template processing. This change refactors the code to use the same instead of repetitive methods in all shared libraries.
Issues Resolved
opensearch-project/opensearch-build#5332
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.