Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add library to check and notify release notes based on old workflow #626

Merged
merged 3 commits into from
Mar 21, 2025

Conversation

gaiksaya
Copy link
Member

Description

The python release workflow in build-repo generates a markdown table in the format: opensearch-project/opensearch-build#3747 (comment)
This change adds below things:

  • Adds a class to parse the markdown file and return each component with respective values mapped to the keys.
  • Adds a new library that will check or notify the release owners about the missing release notes.

Issues Resolved

opensearch-project/opensearch-build#5332

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Copy link

codecov bot commented Mar 18, 2025

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.15%. Comparing base (5901476) to head (35ee84c).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/jenkins/ReleaseMetricsData.groovy 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #626      +/-   ##
============================================
+ Coverage     88.86%   89.15%   +0.28%     
- Complexity      109      111       +2     
============================================
  Files           115      116       +1     
  Lines           530      544      +14     
  Branches         30       30              
============================================
+ Hits            471      485      +14     
  Misses           29       29              
  Partials         30       30              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@zelinh zelinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gaiksaya, could you look into the CodeCov failing here?

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
@gaiksaya
Copy link
Member Author

Thanks @gaiksaya, could you look into the CodeCov failing here?

Added a test for exception as well.

@gaiksaya gaiksaya merged commit 7ebe7d2 into opensearch-project:main Mar 21, 2025
9 checks passed
@gaiksaya gaiksaya deleted the add-release-notes branch March 21, 2025 21:46
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 24, 2025
…626)

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
(cherry picked from commit 7ebe7d2)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants