Add qualifier support to metrics queries #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
gaiksaya
requested review from
peterzhuamazon,
prudhvigodithi,
rishabh6788,
Divyaasm and
zelinh
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #611 +/- ##
============================================
- Coverage 90.21% 88.84% -1.37%
- Complexity 94 109 +15
============================================
Files 114 114
Lines 511 529 +18
Branches 24 30 +6
============================================
+ Hits 461 470 +9
- Misses 26 29 +3
- Partials 24 30 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -106,6 +115,13 @@ class ComponentIntegTestStatus { | |||
| ] | |||
| ] | |||
| ] | |||
| if (this.qualifier != null && this.qualifier != "None") { | |||
There was a problem hiding this comment.
Too many of this calls can we replace with:
There was a problem hiding this comment.
We want to check for "None" as that is what is indexed by default for non-qualifiers while indexing data.
There was a problem hiding this comment.
Added a private method to incorporate above logic.
Thanks!
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
peterzhuamazon
approved these changes
Mar 12, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 12, 2025
(cherry picked from commit 822d25f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add qualifier support to metrics queries
Issues Resolved
Work around solution for opensearch-project/opensearch-build#5386
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.