Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new procedure polling-ingest-index-only to geonames #578

Merged
merged 3 commits into from
Mar 24, 2025

Conversation

xuxiong1
Copy link
Contributor

@xuxiong1 xuxiong1 commented Mar 6, 2025

Description

This PR adds a new polling-ingest-index-only procedure to geonames to support running benchmarks for polling ingestion, which is implemented in opensearch-project/opensearch-benchmark#784

Issues Resolved

related to issue: opensearch-project/OpenSearch#17086

Testing

  • New functionality includes testing

Tested in PR #784


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: xuxiong1 <xiongxug@outlook.com>
Copy link
Collaborator

@IanHoang IanHoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@xuxiong1 please confirm if this should only be back ported to branches 2 and 3?

Also, do we see any benefit of having this test procedure available in other commonly-used workloads like Big5?

@xuxiong1
Copy link
Contributor Author

@IanHoang I think it should only be backported to 3? Since the feature is only available in the open search 3.0 version.

Yes, as the different datasets may result in different ingest performances. We could explore supporting other commonly used workloads later!

Signed-off-by: xuxiong1 <xiongxug@outlook.com>
Signed-off-by: xuxiong1 <xiongxug@outlook.com>
@OVI3D0 OVI3D0 merged commit 3731c16 into opensearch-project:main Mar 24, 2025
2 checks passed
@OVI3D0 OVI3D0 added the backport 3 Backport to the "3" branch label Mar 24, 2025
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 24, 2025
* add new polling-ingest-index-only procedure

Signed-off-by: xuxiong1 <xiongxug@outlook.com>

* add ingestion_pointer_init_reset

Signed-off-by: xuxiong1 <xiongxug@outlook.com>

* add index name to check cluster health

Signed-off-by: xuxiong1 <xiongxug@outlook.com>

---------

Signed-off-by: xuxiong1 <xiongxug@outlook.com>
(cherry picked from commit 3731c16)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
OVI3D0 pushed a commit that referenced this pull request Mar 25, 2025
* add new polling-ingest-index-only procedure



* add ingestion_pointer_init_reset



* add index name to check cluster health



---------


(cherry picked from commit 3731c16)

Signed-off-by: xuxiong1 <xiongxug@outlook.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 3 Backport to the "3" branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants