Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update CB setting to 100 to bypass memory check #3627

Merged
merged 1 commit into from
Mar 8, 2025

Conversation

Zhangxunmt
Copy link
Collaborator

Description

Update the CB setting to 100 to bypass the memory check for remote models.

Related Issues

#3544

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dhrubo-os
Copy link
Collaborator

apply spotless

Signed-off-by: Xun Zhang <xunzh@amazon.com>
@Zhangxunmt Zhangxunmt had a problem deploying to ml-commons-cicd-env March 5, 2025 22:27 — with GitHub Actions Failure
@ylwu-amzn
Copy link
Collaborator

CI failed

REPRODUCE WITH: ./gradlew ':opensearch-ml-plugin:integTest' --tests "org.opensearch.ml.rest.RestBedRockInferenceIT.test_bedrock_embedding_v2_model_with_postProcessFunction" -Dtests.seed=F3691E4858960B16 -Dtests.security.manager=false -Dtests.locale=rm-Latn-CH -Dtests.timezone=MST7MDT -Druntime.java=21
    [2025-03-05T16:03:43,335][INFO ][o.o.m.r.RestBedRockInferenceIT] [test_bedrock_embedding_v2_model_with_postProcessFunction] after test

RestBedRockInferenceIT > test_bedrock_embedding_v2_model_with_postProcessFunction STANDARD_ERROR
    REPRODUCE WITH: ./gradlew ':opensearch-ml-plugin:integTest' --tests "org.opensearch.ml.rest.RestBedRockInferenceIT.test_bedrock_embedding_v2_model_with_postProcessFunction" -Dtests.seed=F3691E4858960B16 -Dtests.security.manager=false -Dtests.locale=rm-Latn-CH -Dtests.timezone=MST7MDT -Druntime.java=21

RestBedRockInferenceIT > test_bedrock_embedding_v2_model_with_postProcessFunction FAILED
    java.lang.NullPointerException: Cannot invoke "Object.getClass()" because the return value of "java.util.Map.get(Object)" is null
        at __randomizedtesting.SeedInfo.seed([F3691E4858960B16:E1204C70D840FB24]:0)
        at org.opensearch.ml.rest.RestBedRockInferenceIT.validateOutput(RestBedRockInferenceIT.java:307)
        at org.opensearch.ml.rest.RestBedRockInferenceIT.test_bedrock_embedding_v2_model_with_postProcessFunction(RestBedRockInferenceIT.java:294)

RestBedRockInferenceIT > test_bedrock_multimodal_model_empty_imageInput_null_textInput STANDARD_OUT
    [2025-03-05T16:03:43,350][INFO ][o.o.m.r.RestBedRockInferenceIT] [test_bedrock_multimodal_model_empty_imageInput_null_textInput] before test
Error: 25-03-05T16:04:04,642][ERROR][o.o.m.r.MLCommonsRestTestCase] [test_bedrock_multimodal_model_empty_imageInput_null_textInput] method [POST], host [http://127.0.0.1:35007/], URI [/_plugins/_ml/_predict/TEXT_EMBEDDING/ACKNaJUB7Ni-GyncR9CX], status line [HTTP/1.1 400 Bad Request]
    {"error":{"root_cause":[{"type":"illegal_argument_exception","reason":"No input text or image provided"}],"type":"illegal_argument_exception","reason":"No input text or image provided"},"status":400}
    org.opensearch.client.ResponseException: method [POST], host [http://127.0.0.1:35007/], URI [/_plugins/_ml/_predict/TEXT_EMBEDDING/ACKNaJUB7Ni-GyncR9CX], status line [HTTP/1.1 400 Bad Request]
    {"error":{"root_cause":[{"type":"illegal_argument_exception","reason":"No input text or image provided"}],"type":"illegal_argument_exception","reason":"No input text or image provided"},"status":400}
    	at org.opensearch.client.RestClient.convertResponse(RestClient.java:501) ~[opensearch-rest-client-3.0.0-alpha1-SNAPSHOT.jar:3.0.0-alpha1-SNAPSHOT]
    	at org.opensearch.client.RestClient.performRequest(RestClient.java:384) ~[opensearch-rest-client-3.0.0-alpha1-SNAPSHOT.jar:3.0.0-alpha1-SNAPSHOT]
    	at org.opensearch.client.RestClient.performRequest(RestClient.java:359) ~[opensearch-rest-client-3.0.0-alpha1-SNAPSHOT.jar:3.0.0-alpha1-SNAPSHOT]
    	at org.opensearch.ml.utils.TestHelper.makeRequest(TestHelper.java:184) ~[test/:?]
    	at org.opensearch.ml.utils.TestHelper.makeRequest(TestHelper.java:157) ~[test/:?]
    	at org.opensearch.ml.utils.TestHelper.makeRequest(TestHelper.java:146) ~[test/:?]
    	at org.opensearch.ml.rest.MLCommonsRestTestCase.predictTextEmbeddingModel(MLCommonsRestTestCase.java:925) ~[test/:?]
    	at org.opensearch.ml.rest.RestBedRockInferenceIT.test_bedrock_multimodal_model_empty_imageInput_null_textInput(RestBedRockInferenceIT.java:233) ~[test/:?]
    	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103) ~[?:?]
    	at java.base/java.lang.reflect.Method.invoke(Method.java:580) ~[?:?]

@Zhangxunmt Zhangxunmt had a problem deploying to ml-commons-cicd-env March 6, 2025 17:29 — with GitHub Actions Failure
@Zhangxunmt Zhangxunmt had a problem deploying to ml-commons-cicd-env March 6, 2025 20:00 — with GitHub Actions Failure
@Zhangxunmt Zhangxunmt had a problem deploying to ml-commons-cicd-env March 7, 2025 19:05 — with GitHub Actions Failure
@Zhangxunmt Zhangxunmt merged commit d4ed7f5 into opensearch-project:main Mar 8, 2025
8 of 10 checks passed
akolarkunnu pushed a commit to akolarkunnu/ml-commons that referenced this pull request Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants