Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.19] fix optional mappings in ml inference search processors #3596

Merged
merged 1 commit into from
Feb 28, 2025
Merged

[Backport 2.19] fix optional mappings in ml inference search processors #3596

merged 1 commit into from
Feb 28, 2025

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport b22e61a from #3587

@mingshl @github-actions
fix optional mappings in ml inference search processors (#3587)
d5b36a4 
* fix optional mappings

Signed-off-by: Mingshi Liu <mingshl@amazon.com>

* use collections and add more assertion tests

Signed-off-by: Mingshi Liu <mingshl@amazon.com>

* validate query return false

Signed-off-by: Mingshi Liu <mingshl@amazon.com>

---------

Signed-off-by: Mingshi Liu <mingshl@amazon.com>
(cherry picked from commit b22e61a)
@mingshl
Copy link
Collaborator

mingshl commented Feb 27, 2025

flaky test:

> Task :opensearch-ml-algorithms:test

AwsConnectorExecutorTest > executePredict_whenRetryEnabled_thenInvokeRemoteServiceWithRetry FAILED
    org.mockito.exceptions.verification.NeverWantedButInvoked at AwsConnectorExecutorTest.java:764

537 tests completed, 1 failed, 6 skipped


FAILURE: Build failed with an exception.
> Task :opensearch-ml-algorithms:test FAILED

[Incubating] Problems report is available at: file:///D:/a/ml-commons/ml-commons/build/reports/problems/problems-report.html
* What went wrong:

Execution failed for task ':opensearch-ml-algorithms:test'.
Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.
> There were failing tests. See the report at: file:///D:/a/ml-commons/ml-commons/ml-algorithms/build/reports/tests/test/index.html

@mingshl mingshl merged commit cc630d0 into 2.19 Feb 28, 2025
8 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ylwu-amzn ylwu-amzn ylwu-amzn approved these changes

@mingshl mingshl mingshl approved these changes

@b4sjoo b4sjoo Awaiting requested review from b4sjoo b4sjoo is a code owner

@dhrubo-os dhrubo-os Awaiting requested review from dhrubo-os dhrubo-os is a code owner

@jngz-es jngz-es Awaiting requested review from jngz-es jngz-es is a code owner

@model-collapse model-collapse Awaiting requested review from model-collapse model-collapse is a code owner

@rbhavna rbhavna Awaiting requested review from rbhavna rbhavna is a code owner

@zane-neo zane-neo Awaiting requested review from zane-neo zane-neo is a code owner

@Zhangxunmt Zhangxunmt Awaiting requested review from Zhangxunmt Zhangxunmt is a code owner

@austintlee austintlee Awaiting requested review from austintlee austintlee is a code owner

@HenryL27 HenryL27 Awaiting requested review from HenryL27 HenryL27 is a code owner

@xinyual xinyual Awaiting requested review from xinyual xinyual is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mingshl @ylwu-amzn