Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jacoco result not updated to latest commit issue #3581

Closed
wants to merge 14 commits into from

Conversation

zane-neo
Copy link
Collaborator

Description

Fix jacoco result not updated to latest commit issue

Related Issues

#3580

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@zane-neo
Copy link
Collaborator Author

@peterzhuamazon Can you help review this PR? Thanks.

peterzhuamazon
peterzhuamazon previously approved these changes Feb 27, 2025
Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve based on @zane-neo confirming that jacoco file exist in plugin/build/reports/jacoco/test/jacocoTestReport.xml.

Need to open another PR to confirm.

Thanks.

@zane-neo zane-neo had a problem deploying to ml-commons-cicd-env March 11, 2025 04:14 — with GitHub Actions Failure
Signed-off-by: zane-neo <zaniu@amazon.com>
Signed-off-by: zane-neo <zaniu@amazon.com>
@zane-neo zane-neo temporarily deployed to ml-commons-cicd-env March 11, 2025 05:56 — with GitHub Actions Inactive
@zane-neo zane-neo had a problem deploying to ml-commons-cicd-env March 11, 2025 05:56 — with GitHub Actions Failure
@zane-neo zane-neo temporarily deployed to ml-commons-cicd-env March 11, 2025 05:56 — with GitHub Actions Inactive
Signed-off-by: zane-neo <zaniu@amazon.com>
@zane-neo zane-neo temporarily deployed to ml-commons-cicd-env March 11, 2025 06:33 — with GitHub Actions Inactive
@zane-neo zane-neo temporarily deployed to ml-commons-cicd-env March 11, 2025 06:33 — with GitHub Actions Inactive
@zane-neo zane-neo temporarily deployed to ml-commons-cicd-env March 11, 2025 06:33 — with GitHub Actions Inactive
@zane-neo zane-neo temporarily deployed to ml-commons-cicd-env March 11, 2025 06:33 — with GitHub Actions Inactive
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 18.18182% with 36 lines in your changes missing coverage. Please review.

Project coverage is 80.12%. Comparing base (7d1f002) to head (59f15ca).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
...org/opensearch/ml/utils/MLNodeUtilsForTesting.java 18.18% 35 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3581      +/-   ##
============================================
- Coverage     80.28%   80.12%   -0.17%     
- Complexity     6935     6984      +49     
============================================
  Files           610      616       +6     
  Lines         30296    30624     +328     
  Branches       3388     3444      +56     
============================================
+ Hits          24324    24536     +212     
- Misses         4510     4591      +81     
- Partials       1462     1497      +35     
Flag Coverage Δ
ml-commons 80.12% <18.18%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zane-neo zane-neo had a problem deploying to ml-commons-cicd-env March 11, 2025 07:31 — with GitHub Actions Failure
Signed-off-by: zane-neo <zaniu@amazon.com>
Signed-off-by: zane-neo <zaniu@amazon.com>
Signed-off-by: zane-neo <zaniu@amazon.com>
@zane-neo zane-neo temporarily deployed to ml-commons-cicd-env March 11, 2025 09:25 — with GitHub Actions Inactive
@zane-neo zane-neo temporarily deployed to ml-commons-cicd-env March 11, 2025 09:25 — with GitHub Actions Inactive
@zane-neo zane-neo temporarily deployed to ml-commons-cicd-env March 11, 2025 09:25 — with GitHub Actions Inactive
@zane-neo zane-neo temporarily deployed to ml-commons-cicd-env March 11, 2025 09:25 — with GitHub Actions Inactive
@zane-neo zane-neo had a problem deploying to ml-commons-cicd-env March 11, 2025 10:23 — with GitHub Actions Failure
@zane-neo
Copy link
Collaborator Author

Closing this PR as it seems the code coverage is updating automatically.

@zane-neo zane-neo closed this Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants