Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Enhance validation for create connector API #3579

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Enhancement] Enhance validation for create connector API #3579

wants to merge 2 commits into from

Conversation

akolarkunnu
Copy link
Contributor

Description

This change will address the second part of validation "pre and post processing function validation".
Moved the method getRemoteServerFromURL() from ConnectorUtils.java to ConnectorAction.java, to avoid the cyclic dependency

Related Issues

Partially resolves #2993

Check List

  • New functionality includes testing.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@akolarkunnu akolarkunnu requested a deployment to ml-commons-cicd-env-require-approval February 21, 2025 11:12 — with GitHub Actions Waiting
@akolarkunnu akolarkunnu requested a deployment to ml-commons-cicd-env-require-approval February 21, 2025 11:12 — with GitHub Actions Waiting
@akolarkunnu akolarkunnu requested a deployment to ml-commons-cicd-env-require-approval February 21, 2025 11:12 — with GitHub Actions Waiting
@akolarkunnu akolarkunnu requested a deployment to ml-commons-cicd-env-require-approval February 21, 2025 11:12 — with GitHub Actions Waiting
@akolarkunnu akolarkunnu had a problem deploying to ml-commons-cicd-env-require-approval February 24, 2025 11:09 — with GitHub Actions Error
@akolarkunnu akolarkunnu temporarily deployed to ml-commons-cicd-env-require-approval February 24, 2025 11:09 — with GitHub Actions Inactive
@akolarkunnu akolarkunnu temporarily deployed to ml-commons-cicd-env-require-approval February 24, 2025 11:09 — with GitHub Actions Inactive
@akolarkunnu akolarkunnu had a problem deploying to ml-commons-cicd-env-require-approval February 24, 2025 11:09 — with GitHub Actions Failure
@akolarkunnu
Copy link
Contributor Author

Can anyone trigger the failed test suite once more, failure doesn't have any relation with changes.

@akolarkunnu akolarkunnu had a problem deploying to ml-commons-cicd-env-require-approval February 26, 2025 07:11 — with GitHub Actions Error
@akolarkunnu akolarkunnu had a problem deploying to ml-commons-cicd-env-require-approval February 26, 2025 07:11 — with GitHub Actions Failure
@akolarkunnu akolarkunnu had a problem deploying to ml-commons-cicd-env-require-approval February 26, 2025 19:35 — with GitHub Actions Failure
@akolarkunnu akolarkunnu had a problem deploying to ml-commons-cicd-env-require-approval March 3, 2025 20:19 — with GitHub Actions Failure
@akolarkunnu akolarkunnu had a problem deploying to ml-commons-cicd-env-require-approval March 3, 2025 20:19 — with GitHub Actions Error
@akolarkunnu akolarkunnu requested a deployment to ml-commons-cicd-env-require-approval March 11, 2025 08:49 — with GitHub Actions Waiting
@akolarkunnu akolarkunnu requested a deployment to ml-commons-cicd-env-require-approval March 11, 2025 08:49 — with GitHub Actions Waiting
@akolarkunnu akolarkunnu requested a deployment to ml-commons-cicd-env-require-approval March 11, 2025 08:49 — with GitHub Actions Waiting
@akolarkunnu akolarkunnu requested a deployment to ml-commons-cicd-env-require-approval March 11, 2025 08:51 — with GitHub Actions Waiting
@akolarkunnu akolarkunnu requested a deployment to ml-commons-cicd-env-require-approval March 11, 2025 08:51 — with GitHub Actions Waiting
@akolarkunnu akolarkunnu requested a deployment to ml-commons-cicd-env-require-approval March 11, 2025 08:51 — with GitHub Actions Waiting
@akolarkunnu akolarkunnu requested a deployment to ml-commons-cicd-env-require-approval March 11, 2025 08:51 — with GitHub Actions Waiting
@akolarkunnu akolarkunnu marked this pull request as draft March 11, 2025 16:01
@akolarkunnu akolarkunnu marked this pull request as ready for review March 11, 2025 16:01
@akolarkunnu akolarkunnu force-pushed the prepostfuncvalidation branch from 1667623 to d4ed7f5 Compare March 11, 2025 17:22
@akolarkunnu akolarkunnu requested a deployment to ml-commons-cicd-env-require-approval March 11, 2025 17:23 — with GitHub Actions Waiting
@akolarkunnu akolarkunnu requested a deployment to ml-commons-cicd-env-require-approval March 11, 2025 17:23 — with GitHub Actions Waiting
@akolarkunnu akolarkunnu requested a deployment to ml-commons-cicd-env-require-approval March 11, 2025 17:23 — with GitHub Actions Waiting
@akolarkunnu akolarkunnu requested a deployment to ml-commons-cicd-env-require-approval March 11, 2025 17:23 — with GitHub Actions Waiting
@akolarkunnu
[Enhancement] Enhance validation for create connector API
7df638e 
This change will address the second part of validation "pre and post processing function validation".

Partially resolves opensearch-project#2993

Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>
@akolarkunnu akolarkunnu reopened this Mar 11, 2025
@akolarkunnu akolarkunnu requested a deployment to ml-commons-cicd-env-require-approval March 11, 2025 17:33 — with GitHub Actions Waiting
@akolarkunnu akolarkunnu requested a deployment to ml-commons-cicd-env-require-approval March 11, 2025 17:33 — with GitHub Actions Waiting
@akolarkunnu akolarkunnu requested a deployment to ml-commons-cicd-env-require-approval March 11, 2025 17:33 — with GitHub Actions Waiting
@akolarkunnu akolarkunnu requested a deployment to ml-commons-cicd-env-require-approval March 11, 2025 17:33 — with GitHub Actions Waiting
@akolarkunnu akolarkunnu had a problem deploying to ml-commons-cicd-env-require-approval March 11, 2025 17:33 — with GitHub Actions Failure
@akolarkunnu akolarkunnu had a problem deploying to ml-commons-cicd-env-require-approval March 11, 2025 17:33 — with GitHub Actions Error
@akolarkunnu akolarkunnu had a problem deploying to ml-commons-cicd-env-require-approval March 11, 2025 17:33 — with GitHub Actions Error
@akolarkunnu akolarkunnu had a problem deploying to ml-commons-cicd-env-require-approval March 11, 2025 17:33 — with GitHub Actions Failure
@akolarkunnu
[Enhancement] Enhance validation for create connector API
236fda2 
This change will address the second part of validation "pre and post processing function validation".

Partially resolves opensearch-project#2993

Signed-off-by: Abdul Muneer Kolarkunnu <muneer.kolarkunnu@netapp.com>
@akolarkunnu akolarkunnu had a problem deploying to ml-commons-cicd-env-require-approval March 12, 2025 06:04 — with GitHub Actions Failure
@akolarkunnu akolarkunnu temporarily deployed to ml-commons-cicd-env-require-approval March 12, 2025 06:04 — with GitHub Actions Inactive
@akolarkunnu akolarkunnu had a problem deploying to ml-commons-cicd-env-require-approval March 12, 2025 06:04 — with GitHub Actions Error
@akolarkunnu akolarkunnu deployed to ml-commons-cicd-env-require-approval March 12, 2025 06:04 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyek-bot pyek-bot pyek-bot left review comments

@b4sjoo b4sjoo Awaiting requested review from b4sjoo b4sjoo is a code owner

@dhrubo-os dhrubo-os Awaiting requested review from dhrubo-os dhrubo-os is a code owner

@mingshl mingshl Awaiting requested review from mingshl mingshl is a code owner

@jngz-es jngz-es Awaiting requested review from jngz-es jngz-es is a code owner

@model-collapse model-collapse Awaiting requested review from model-collapse model-collapse is a code owner

@rbhavna rbhavna Awaiting requested review from rbhavna rbhavna is a code owner

@ylwu-amzn ylwu-amzn Awaiting requested review from ylwu-amzn ylwu-amzn is a code owner

@zane-neo zane-neo Awaiting requested review from zane-neo zane-neo is a code owner

@Zhangxunmt Zhangxunmt Awaiting requested review from Zhangxunmt Zhangxunmt is a code owner

@austintlee austintlee Awaiting requested review from austintlee austintlee is a code owner

@HenryL27 HenryL27 Awaiting requested review from HenryL27 HenryL27 is a code owner

@xinyual xinyual Awaiting requested review from xinyual xinyual is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] Enhance validation for create connector API
2 participants
@akolarkunnu @pyek-bot