[Backport 2.x] support batch task management by periodically polling the remote task via a cron job #3458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
… via a cron job (#3421) * support batch task management by periocially bolling the remote task via a cron job Signed-off-by: Bhavana Goud Ramaram <rbhavna@amazon.com> * address comments and resolve dependencies to avoid conflicts Signed-off-by: Bhavana Goud Ramaram <rbhavna@amazon.com> * add unit tests Signed-off-by: Bhavana Goud Ramaram <rbhavna@amazon.com> * renamed files and added more tests Signed-off-by: Bhavana Goud Ramaram <rbhavna@amazon.com> --------- Signed-off-by: Bhavana Goud Ramaram <rbhavna@amazon.com> (cherry picked from commit 161d789)
opensearch-trigger-bot
bot
requested review from
b4sjoo,
dhrubo-os,
mingshl,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27 and
xinyual
as code owners
opensearch-trigger-bot
bot
had a problem deploying
to
ml-commons-cicd-env
opensearch-trigger-bot
bot
had a problem deploying
to
ml-commons-cicd-env
opensearch-trigger-bot
bot
had a problem deploying
to
ml-commons-cicd-env
opensearch-trigger-bot
bot
had a problem deploying
to
ml-commons-cicd-env
opensearch-trigger-bot
bot
had a problem deploying
to
ml-commons-cicd-env
opensearch-trigger-bot
bot
temporarily deployed
to
ml-commons-cicd-env
Signed-off-by: Bhavana Goud Ramaram <rbhavna@amazon.com>
rbhavna
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
rbhavna
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
rbhavna
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
rbhavna
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
rbhavna
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
rbhavna
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
Zhangxunmt
previously approved these changes
Jan 29, 2025
Signed-off-by: Bhavana Goud Ramaram <rbhavna@amazon.com>
rbhavna
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
b4sjoo
previously approved these changes
Jan 29, 2025
plugin/build.gradle
Outdated
| String opensearchMlPlugin = "opensearch-ml-" + project.version + ".zip" | ||
|
|
||
| String bwcJobSchedulerPlugin = "opensearch-job-scheduler-" + bwcVersion + ".zip" | ||
| String bwcRemoteJobSchedulerFile = "https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/" + bwcShortVersion + "/latest/linux/x64/tar/builds/opensearch/plugins/" + bwcJobSchedulerPlugin |
There was a problem hiding this comment.
Nit: maybe change the “https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/” + bwcShortVersion + “/latest/linux/x64/tar/builds/opensearch/plugins/” into something like bwcRemoteBaseUrl to improve the readibility
plugin/build.gradle
Outdated
| @@ -429,40 +479,74 @@ tasks.withType(licenseHeaders.class) { | |||
| String bwcVersion = "2.4.0.0" | |||
| String bwcShortVersion = bwcVersion[0..4] | |||
| String baseName = "mlCommonsBwcCluster" | |||
| String bwcBasePath = "src/test/resources/org/opensearch/ml/bwc/" | |||
| String bwcMLFilePath = "src/test/resources/org/opensearch/ml/bwc/ml/" | |||
There was a problem hiding this comment.
Nit: Why not use bwcBasePath + "ml/" or bwcBasePath + "job-scheduler/" here
Signed-off-by: Bhavana Goud Ramaram <rbhavna@amazon.com>
rbhavna
approved these changes
Jan 29, 2025
rbhavna
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
rbhavna
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
rbhavna
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
rbhavna
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
rbhavna
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
rbhavna
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
b4sjoo
approved these changes
Jan 29, 2025
|
LGTM, thanks for repairing the bwc, great ownership |
rbhavna
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
rbhavna
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
rbhavna
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
rbhavna
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
rbhavna
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
rbhavna
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
rbhavna
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
rbhavna
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
rbhavna
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
rbhavna
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
rbhavna
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
rbhavna
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
opensearch-trigger-bot bot
added a commit
that referenced
this pull request
Jan 30, 2025
…the remote task via a cron job (#3458) * support batch task management by periodically bolling the remote task via a cron job (#3421) * support batch task management by periocially bolling the remote task via a cron job Signed-off-by: Bhavana Goud Ramaram <rbhavna@amazon.com> * address comments and resolve dependencies to avoid conflicts Signed-off-by: Bhavana Goud Ramaram <rbhavna@amazon.com> * add unit tests Signed-off-by: Bhavana Goud Ramaram <rbhavna@amazon.com> * renamed files and added more tests Signed-off-by: Bhavana Goud Ramaram <rbhavna@amazon.com> --------- Signed-off-by: Bhavana Goud Ramaram <rbhavna@amazon.com> (cherry picked from commit 161d789) * fix failing BWC tests Signed-off-by: Bhavana Goud Ramaram <rbhavna@amazon.com> * fix missing path in failing BWC tests Signed-off-by: Bhavana Goud Ramaram <rbhavna@amazon.com> * fix failing BWC tests Signed-off-by: Bhavana Goud Ramaram <rbhavna@amazon.com> * add missing braces Signed-off-by: Bhavana Goud Ramaram <rbhavna@amazon.com> * add missing braces Signed-off-by: Bhavana Goud Ramaram <rbhavna@amazon.com> * add missing braces Signed-off-by: Bhavana Goud Ramaram <rbhavna@amazon.com> * add missing braces Signed-off-by: Bhavana Goud Ramaram <rbhavna@amazon.com> * add missing braces Signed-off-by: Bhavana Goud Ramaram <rbhavna@amazon.com> * add to yml file Signed-off-by: Bhavana Goud Ramaram <rbhavna@amazon.com> * add to yml file Signed-off-by: Bhavana Goud Ramaram <rbhavna@amazon.com> * add to yml file Signed-off-by: Bhavana Goud Ramaram <rbhavna@amazon.com> * refactored code Signed-off-by: Bhavana Goud Ramaram <rbhavna@amazon.com> --------- Signed-off-by: Bhavana Goud Ramaram <rbhavna@amazon.com> Co-authored-by: Bhavana Goud Ramaram <rbhavna@amazon.com> (cherry picked from commit f083b7e)
Zhangxunmt
pushed a commit
that referenced
this pull request
Jan 30, 2025
…the remote task via a cron job (#3458) (#3473) * support batch task management by periodically bolling the remote task via a cron job (#3421) * support batch task management by periocially bolling the remote task via a cron job Signed-off-by: Bhavana Goud Ramaram <rbhavna@amazon.com> * address comments and resolve dependencies to avoid conflicts Signed-off-by: Bhavana Goud Ramaram <rbhavna@amazon.com> * add unit tests Signed-off-by: Bhavana Goud Ramaram <rbhavna@amazon.com> * renamed files and added more tests Signed-off-by: Bhavana Goud Ramaram <rbhavna@amazon.com> --------- Signed-off-by: Bhavana Goud Ramaram <rbhavna@amazon.com> (cherry picked from commit 161d789) * fix failing BWC tests Signed-off-by: Bhavana Goud Ramaram <rbhavna@amazon.com> * fix missing path in failing BWC tests Signed-off-by: Bhavana Goud Ramaram <rbhavna@amazon.com> * fix failing BWC tests Signed-off-by: Bhavana Goud Ramaram <rbhavna@amazon.com> * add missing braces Signed-off-by: Bhavana Goud Ramaram <rbhavna@amazon.com> * add missing braces Signed-off-by: Bhavana Goud Ramaram <rbhavna@amazon.com> * add missing braces Signed-off-by: Bhavana Goud Ramaram <rbhavna@amazon.com> * add missing braces Signed-off-by: Bhavana Goud Ramaram <rbhavna@amazon.com> * add missing braces Signed-off-by: Bhavana Goud Ramaram <rbhavna@amazon.com> * add to yml file Signed-off-by: Bhavana Goud Ramaram <rbhavna@amazon.com> * add to yml file Signed-off-by: Bhavana Goud Ramaram <rbhavna@amazon.com> * add to yml file Signed-off-by: Bhavana Goud Ramaram <rbhavna@amazon.com> * refactored code Signed-off-by: Bhavana Goud Ramaram <rbhavna@amazon.com> --------- Signed-off-by: Bhavana Goud Ramaram <rbhavna@amazon.com> Co-authored-by: Bhavana Goud Ramaram <rbhavna@amazon.com> (cherry picked from commit f083b7e) Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 161d789 from #3421