Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACKPORT 2.x] applying multi-tenancy in search [model, model group, agent, connector] (#3433) #3443

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

dhrubo-os
Copy link
Collaborator

[BACKPORT 2.x] applying multi-tenancy in search [model, model group, agent, connector] (#3433)

  • applying multi-tenancy in search

  • addressed comments


Description

[Describe what this change achieves]

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@jngz-es
Copy link
Collaborator

jngz-es commented Jan 28, 2025

Hi @dhrubo-os , take a look at the below error?

MLSearchActionRequestTest > testMixedVersionCompatibility FAILED
    java.io.IOException at MLSearchActionRequestTest.java:143

@dhrubo-os
Copy link
Collaborator Author

Hi @dhrubo-os , take a look at the below error?

MLSearchActionRequestTest > testMixedVersionCompatibility FAILED
    java.io.IOException at MLSearchActionRequestTest.java:143

Yup, looking at this. Thanks.

…r] (opensearch-project#3433)

* applying multi-tenancy in search

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

* addressed comments

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

---------

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
…nRequest

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
@dhrubo-os dhrubo-os merged commit 34a7fb6 into opensearch-project:2.x Jan 30, 2025
11 of 14 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 30, 2025
…agent, connector] (#3433) (#3443)

* applying multi-tenancy in search [model, model group, agent, connector] (#3433)

* applying multi-tenancy in search

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

* addressed comments

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

---------

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

* changing MLSearchActionRequest to an instance subclass of SearchActionRequest

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

---------

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
(cherry picked from commit 34a7fb6)
dhrubo-os added a commit that referenced this pull request Jan 30, 2025
…agent, connector] (#3433) (#3443) (#3469)

* applying multi-tenancy in search [model, model group, agent, connector] (#3433)

* applying multi-tenancy in search

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

* addressed comments

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

---------

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

* changing MLSearchActionRequest to an instance subclass of SearchActionRequest

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

---------

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
(cherry picked from commit 34a7fb6)

Co-authored-by: Dhrubo Saha <dhrubo@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants