Checkout code from pull request head for spotless #3422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rithin-pullela-aws <rithinp@amazon.com>
rithin-pullela-aws
requested review from
b4sjoo,
dhrubo-os,
mingshl,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27 and
xinyual
as code owners
rithin-pullela-aws
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
rithin-pullela-aws
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
dhrubo-os
previously approved these changes
Jan 23, 2025
dhrubo-os
reviewed
Jan 23, 2025
Signed-off-by: rithin-pullela-aws <rithinp@amazon.com>
rithin-pullela-aws
temporarily deployed
to
ml-commons-cicd-env-require-approval
GitHub Actions
Inactive
rithin-pullela-aws
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
|
Approving for now. But can you please check in another PR, if we need to pull again in the line 71-74 as we already pulled the pull request? |
dhrubo-os
approved these changes
Jan 23, 2025
b4sjoo
approved these changes
Jan 23, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 23, 2025
* Checkout code from pull request head for spotless Signed-off-by: rithin-pullela-aws <rithinp@amazon.com> * Add name to the ML-Commons checkout Signed-off-by: rithin-pullela-aws <rithinp@amazon.com> --------- Signed-off-by: rithin-pullela-aws <rithinp@amazon.com> (cherry picked from commit 06a2b40)
dhrubo-os
pushed a commit
that referenced
this pull request
Jan 23, 2025
* Checkout code from pull request head for spotless Signed-off-by: rithin-pullela-aws <rithinp@amazon.com> * Add name to the ML-Commons checkout Signed-off-by: rithin-pullela-aws <rithinp@amazon.com> --------- Signed-off-by: rithin-pullela-aws <rithinp@amazon.com> (cherry picked from commit 06a2b40) Co-authored-by: Rithin Pullela <rithinp@amazon.com>
I believe we need to do that @dhrubo-os, because it is a different job altogether. It is similar to the way we setup JAVA every time in each of the jobs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Without this it pulls the code without the updates specific to the PR.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.