Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport to 2.x] applying multi-tenancy to task apis, deploy, predict apis (#3416) #3420

Merged
merged 1 commit into from
Jan 23, 2025
Merged

[Backport to 2.x] applying multi-tenancy to task apis, deploy, predict apis (#3416) #3420

merged 1 commit into from
Jan 23, 2025

Conversation

dhrubo-os
Copy link
Collaborator

[Backport to 2.x] for 3416

Description

[Describe what this change achieves]

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dhrubo-os
applying multi-tenancy to task apis, deploy, predict apis (opensearch…
0a97d7b 
…-project#3416)

* applying multi-tenancy to task, deploy, predict

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

* addressed comments

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>

---------

Signed-off-by: Dhrubo Saha <dhrubo@amazon.com>
@dhrubo-os dhrubo-os temporarily deployed to ml-commons-cicd-env January 23, 2025 05:22 — with GitHub Actions Inactive
@codecov Codecov
Copy link

codecov bot commented Jan 23, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 65.94724% with 142 lines in your changes missing coverage. Please review.

Project coverage is 80.18%. Comparing base (66aa200) to head (0a97d7b).
Report is 160 commits behind head on 2.x.

Files with missing lines Patch % Lines
...ain/java/org/opensearch/ml/task/MLTaskManager.java 61.03% 25 Missing and 5 partials ⚠️
...search/ml/action/tasks/GetTaskTransportAction.java 68.47% 22 Missing and 7 partials ⚠️
...h/ml/action/deploy/TransportDeployModelAction.java 52.77% 14 Missing and 3 partials ⚠️
...rch/ml/action/tasks/DeleteTaskTransportAction.java 77.92% 13 Missing and 4 partials ⚠️
...src/main/java/org/opensearch/ml/common/MLTask.java 25.00% 6 Missing and 3 partials ⚠️
.../ml/common/transport/task/MLTaskDeleteRequest.java 0.00% 7 Missing ⚠️
...pensearch/ml/client/MachineLearningNodeClient.java 14.28% 6 Missing ⚠️
...rg/opensearch/ml/client/MachineLearningClient.java 33.33% 4 Missing ⚠️
.../transport/prediction/MLPredictionTaskRequest.java 50.00% 2 Missing and 2 partials ⚠️
...nsearch/ml/autoredeploy/MLModelAutoReDeployer.java 33.33% 0 Missing and 4 partials ⚠️
... and 7 more
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x    #3420      +/-   ##
============================================
- Coverage     81.34%   80.18%   -1.17%     
- Complexity     6105     6676     +571     
============================================
  Files           573      599      +26     
  Lines         25311    29038    +3727     
  Branches       2665     3211     +546     
============================================
+ Hits          20590    23284    +2694     
- Misses         3603     4367     +764     
- Partials       1118     1387     +269
Flag Coverage Δ
ml-commons 80.18% <65.94%> (-1.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dhrubo-os dhrubo-os temporarily deployed to ml-commons-cicd-env January 23, 2025 06:18 — with GitHub Actions Inactive
@dhrubo-os dhrubo-os temporarily deployed to ml-commons-cicd-env January 23, 2025 20:31 — with GitHub Actions Inactive
@dhrubo-os dhrubo-os temporarily deployed to ml-commons-cicd-env January 23, 2025 20:31 — with GitHub Actions Inactive
b4sjoo
b4sjoo reviewed Jan 23, 2025
View reviewed changes
common/src/main/java/org/opensearch/ml/common/MLTask.java
}
}
tenantId = streamInputVersion.onOrAfter(VERSION_2_19_0) ? input.readOptionalString() : null;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I may more like to see some name like MINIMAL_SUPPORTED_VERSION_FOR_MULTI_TENANCY, but we can address those later

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3399 (comment)

@mingshl mingshl merged commit ed36d6e into opensearch-project:2.x Jan 23, 2025
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b4sjoo b4sjoo b4sjoo approved these changes

@mingshl mingshl mingshl approved these changes

@jngz-es jngz-es Awaiting requested review from jngz-es jngz-es is a code owner

@model-collapse model-collapse Awaiting requested review from model-collapse model-collapse is a code owner

@rbhavna rbhavna Awaiting requested review from rbhavna rbhavna is a code owner

@ylwu-amzn ylwu-amzn Awaiting requested review from ylwu-amzn ylwu-amzn is a code owner

@zane-neo zane-neo Awaiting requested review from zane-neo zane-neo is a code owner

@Zhangxunmt Zhangxunmt Awaiting requested review from Zhangxunmt Zhangxunmt is a code owner

@austintlee austintlee Awaiting requested review from austintlee austintlee is a code owner

@HenryL27 HenryL27 Awaiting requested review from HenryL27 HenryL27 is a code owner

@xinyual xinyual Awaiting requested review from xinyual xinyual is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhrubo-os @mingshl @b4sjoo