-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Ml Inference Search Request Extension #3284
Introduce Ml Inference Search Request Extension #3284
Conversation
@mingshl let's take the update from main. File has conflict. |
b2504c4
to
d5f7605
Compare
thanks @dhrubo-os , rebased and resolved conflicts. |
Tests are failing |
there is no changes related to ConversationalMemory, will try rerun the tests.
|
d5f7605
to
cfa8a38
Compare
rebased and resolved conflicts. |
|
plugin/src/main/java/org/opensearch/ml/searchext/MLInferenceRequestParametersUtil.java
Show resolved
Hide resolved
Signed-off-by: Mingshi Liu <mingshl@amazon.com>
Signed-off-by: Mingshi Liu <mingshl@amazon.com>
…uest body Signed-off-by: Mingshi Liu <mingshl@amazon.com>
Signed-off-by: Mingshi Liu <mingshl@amazon.com>
d23f14c
to
0960694
Compare
I added two REST tests to verify in the new commit add REST test and javadoc and just rebased the changes from main branch |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3284 +/- ##
============================================
- Coverage 81.31% 80.38% -0.93%
- Complexity 6094 6720 +626
============================================
Files 573 602 +29
Lines 25268 28972 +3704
Branches 2666 3213 +547
============================================
+ Hits 20547 23290 +2743
- Misses 3601 4307 +706
- Partials 1120 1375 +255
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Mingshi Liu <mingshl@amazon.com>
I didn't get the time to review the PR thoroughly. But approving the PR not to block. @austintlee could you please review this PR as you know more of this context. Thanks. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-3284-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3cbd09ab2c9924c9c81214f0d24c20b2f5b58a02
# Push it to GitHub
git push --set-upstream origin backport/backport-3284-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
backport conflict due to this PR also changes in StringUtils, but it merge in main not backport to 2.x yet #3342 |
* add ml inference search extension Signed-off-by: Mingshi Liu <mingshl@amazon.com> * pass search extension to pipeline context Signed-off-by: Mingshi Liu <mingshl@amazon.com> * allow write to requestContext when outputmap's key not present in request body Signed-off-by: Mingshi Liu <mingshl@amazon.com> * add REST test and javadoc Signed-off-by: Mingshi Liu <mingshl@amazon.com> * increase code coverage for StringUtils Signed-off-by: Mingshi Liu <mingshl@amazon.com> --------- Signed-off-by: Mingshi Liu <mingshl@amazon.com> (cherry picked from commit 3cbd09a)
* add ml inference search extension Signed-off-by: Mingshi Liu <mingshl@amazon.com> * pass search extension to pipeline context Signed-off-by: Mingshi Liu <mingshl@amazon.com> * allow write to requestContext when outputmap's key not present in request body Signed-off-by: Mingshi Liu <mingshl@amazon.com> * add REST test and javadoc Signed-off-by: Mingshi Liu <mingshl@amazon.com> * increase code coverage for StringUtils Signed-off-by: Mingshi Liu <mingshl@amazon.com> --------- Signed-off-by: Mingshi Liu <mingshl@amazon.com> (cherry picked from commit 3cbd09a) Co-authored-by: Mingshi Liu <mingshl@amazon.com>
Description
Introduce Ml Inference Search Request Extension, this is adding ml_inference search extension during search request/query phase,
For the search response side, I already introduced a
ml_inference
search response extension in earlier PR released in 2.18. Support ML Inference Search Processor Writing to Search ExtensionRelated Issues
#3286
#3054
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.