Use _list/indices API instead of _cat/index API in CatIndexTool

[zane-neo]

Description

Use _list/indices API instead of _cat/index API in CatIndexTool

Related Issues

#3182

Check List

• New functionality includes testing.
• New functionality has been documented.
• API changes companion pull request created.
• Commits are signed per the DCO using --signoff.
• Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[dbwiddis]

I don't see where we're properly testing the pagination here.

[ylwu-amzn]

Add a comment on the issue #3182 (comment)

Why not build another ListIndexTool?
List index API introduced in 2.18 https://opensearch.org/docs/latest/api-reference/list/list-indices/. Seems hard to backport fix/enhance of CatIndexTool to older versions by changing it to _list/indices ,

Any thoughts, @zane-neo , @dbwiddis ?

[dbwiddis]

Any thoughts, @zane-neo , @dbwiddis ?

Agreed a new tool would be cleaner. RestIndicesListAction extends RestIndicesAction (that Cat Index uses) so it'd be better to logically extend the other tool with just the updated parameters.

[zane-neo]

Sorry I'm not comfortable to merger a PR without passing any integration test suite. This is not a good practice IMO.

@dhrubo-os I've moved the failure assertion part of the ITs, now the failing ITs are not related to my change, please help approve, thanks.

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-3243-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 17a903736bafe2494795acb0481950af5899143a
# Push it to GitHub
git push --set-upstream origin backport/backport-3243-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-3243-to-2.x.