-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix argument pass #1941
Fix argument pass #1941
Conversation
Signed-off-by: xinyual <xinyual@amazon.com>
Signed-off-by: xinyual <xinyual@amazon.com>
Signed-off-by: xinyual <xinyual@amazon.com>
Signed-off-by: xinyual <xinyual@amazon.com>
The issue is #1942 |
ml-algorithms/src/main/java/org/opensearch/ml/engine/tools/AgentTool.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1941 +/- ##
=========================================
Coverage 82.84% 82.84%
- Complexity 5444 5452 +8
=========================================
Files 522 522
Lines 21900 21924 +24
Branches 2226 2229 +3
=========================================
+ Hits 18143 18164 +21
- Misses 2848 2852 +4
+ Partials 909 908 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
if (parameters.containsKey("input")) { | ||
try { | ||
Map<String, String> chatParameters = gson.fromJson(parameters.get("input"), Map.class); | ||
parameters.putAll(chatParameters); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do this ? Looks it's possible to override the original params in parameters
if they have same key
@@ -135,4 +138,15 @@ public String getDefaultVersion() { | |||
return null; | |||
} | |||
} | |||
|
|||
private void extractFromChatParameters(Map<String, String> parameters) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this for chat only?
Signed-off-by: xinyual <xinyual@amazon.com>
* add logs Signed-off-by: xinyual <xinyual@amazon.com> * option2FixBug Signed-off-by: xinyual <xinyual@amazon.com> * remove useless log Signed-off-by: xinyual <xinyual@amazon.com> * remove useless log Signed-off-by: xinyual <xinyual@amazon.com> * fix spot less Signed-off-by: xinyual <xinyual@amazon.com> * change argument parsing Signed-off-by: xinyual <xinyual@amazon.com> * move common function to utils Signed-off-by: xinyual <xinyual@amazon.com> * checkout for typo Signed-off-by: xinyual <xinyual@amazon.com> * remove useless code Signed-off-by: xinyual <xinyual@amazon.com> * add UTs Signed-off-by: xinyual <xinyual@amazon.com> * apply spotless Signed-off-by: xinyual <xinyual@amazon.com> * add more uts Signed-off-by: xinyual <xinyual@amazon.com> * modify import Signed-off-by: xinyual <xinyual@amazon.com> * protect original parameters Signed-off-by: xinyual <xinyual@amazon.com> --------- Signed-off-by: xinyual <xinyual@amazon.com> (cherry picked from commit 4a6ceba)
* add logs Signed-off-by: xinyual <xinyual@amazon.com> * option2FixBug Signed-off-by: xinyual <xinyual@amazon.com> * remove useless log Signed-off-by: xinyual <xinyual@amazon.com> * remove useless log Signed-off-by: xinyual <xinyual@amazon.com> * fix spot less Signed-off-by: xinyual <xinyual@amazon.com> * change argument parsing Signed-off-by: xinyual <xinyual@amazon.com> * move common function to utils Signed-off-by: xinyual <xinyual@amazon.com> * checkout for typo Signed-off-by: xinyual <xinyual@amazon.com> * remove useless code Signed-off-by: xinyual <xinyual@amazon.com> * add UTs Signed-off-by: xinyual <xinyual@amazon.com> * apply spotless Signed-off-by: xinyual <xinyual@amazon.com> * add more uts Signed-off-by: xinyual <xinyual@amazon.com> * modify import Signed-off-by: xinyual <xinyual@amazon.com> * protect original parameters Signed-off-by: xinyual <xinyual@amazon.com> --------- Signed-off-by: xinyual <xinyual@amazon.com> (cherry picked from commit 4a6ceba) Co-authored-by: xinyual <74362153+xinyual@users.noreply.github.com>
* add logs Signed-off-by: xinyual <xinyual@amazon.com> * option2FixBug Signed-off-by: xinyual <xinyual@amazon.com> * remove useless log Signed-off-by: xinyual <xinyual@amazon.com> * remove useless log Signed-off-by: xinyual <xinyual@amazon.com> * fix spot less Signed-off-by: xinyual <xinyual@amazon.com> * change argument parsing Signed-off-by: xinyual <xinyual@amazon.com> * move common function to utils Signed-off-by: xinyual <xinyual@amazon.com> * checkout for typo Signed-off-by: xinyual <xinyual@amazon.com> * remove useless code Signed-off-by: xinyual <xinyual@amazon.com> * add UTs Signed-off-by: xinyual <xinyual@amazon.com> * apply spotless Signed-off-by: xinyual <xinyual@amazon.com> * add more uts Signed-off-by: xinyual <xinyual@amazon.com> * modify import Signed-off-by: xinyual <xinyual@amazon.com> * protect original parameters Signed-off-by: xinyual <xinyual@amazon.com> --------- Signed-off-by: xinyual <xinyual@amazon.com>
Description
Fix some bug inside chatAgent and flow agent.
ModelTensorOutput
instead of true value.Issues Resolved
#1942
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.