Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE]Main based model registry #389

Draft
wants to merge 75 commits into
base: main
Choose a base branch
from

Conversation

wanglam
Copy link
Collaborator

@wanglam wanglam commented Jan 3, 2025

Description

Describe what this change achieves.

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

ruanyl and others added 30 commits December 25, 2024 14:37
…ensearch-project#63)"

This reverts commit 6bdd0d3.

Signed-off-by: Lin Wang <wonglam@amazon.com>
* feat: add security account API

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: add Show Only My Models button to OwnerFilter

Signed-off-by: Lin Wang <wonglam@amazon.com>

* test: split owner filter select test cases

Signed-off-by: Lin Wang <wonglam@amazon.com>

---------

Signed-off-by: Lin Wang <wonglam@amazon.com>
And also fix an issue that refresh the page always redirect to root path

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
* feat: add more actions in model list

Signed-off-by: raintygao <tygao@amazon.com>

* fix: define constant variable without using useMemo

Signed-off-by: raintygao <tygao@amazon.com>

---------

Signed-off-by: raintygao <tygao@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
* feat: add task getOne API

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: update model upload API

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: add model upload hook

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: add model upload hook to model register form

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: run workflow when branch name like feature/*

Signed-off-by: Lin Wang <wonglam@amazon.com>

* ci: update to recursive match run workflow

Signed-off-by: Lin Wang <wonglam@amazon.com>

* fix: es-lint error fixup

Signed-off-by: Lin Wang <wonglam@amazon.com>

* test: add model task API mock for model register form

Signed-off-by: Lin Wang <wonglam@amazon.com>

* chore: update model upload modelConfig type

Signed-off-by: Lin Wang <wonglam@amazon.com>

* refactor: remove isUploadByURL and change to 'modelURL' in model

Signed-off-by: Lin Wang <wonglam@amazon.com>

---------

Signed-off-by: Lin Wang <wonglam@amazon.com>
…search-project#85)

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
…esign and fix ci failed (opensearch-project#90)

* feat: update help location and flyout content

Signed-off-by: raintygao <tygao@amazon.com>

* chore: add slient param to unit test

Signed-off-by: raintygao <tygao@amazon.com>

* chore: add silent param to unit test

Signed-off-by: raintygao <tygao@amazon.com>

* chore: move silent to workflow

Signed-off-by: raintygao <tygao@amazon.com>

* chore: add watch mode for unit test

Signed-off-by: raintygao <tygao@amazon.com>

---------

Signed-off-by: raintygao <tygao@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
+ Only allow to add maximum 25 tags
+ Not allow to add tag with empty key or value from UI, but tags with both key and value empty are allowed from UI(such tag will be just be ignored)
+ Not allow to add duplicated tags which have the same key-value pairs
+ Tag key length and tag value length cannot exceed 80 characters

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
+ model name max length 60 characters -> 80 characters
+ remove ordinal number from form section title
+ add missing tag description to form tag section

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
* feat: add metrics validation

Signed-off-by: raintygao <tygao@amazon.com>

* test: add UT

Signed-off-by: raintygao <tygao@amazon.com>

---------

Signed-off-by: raintygao <tygao@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
+ Form footer will stick at the bottom of the screen
+ Display error counts in the footer

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
…roject#110)

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
* feat: add model_register_button to model_list

Signed-off-by: xyinshen <xyinshen@amazon.com>

* fix: fix some code standards

Signed-off-by: xyinshen <xyinshen@amazon.com>

* fix: fix code with the review comment

Signed-off-by: xyinshen <xyinshen@amazon.com>

* fix: resolve modal scroll bar

Signed-off-by: xyinshen <xyinshen@amazon.com>

* fix: update to only one EuiModalBody

Signed-off-by: xyinshen <xyinshen@amazon.com>

* fix: update EuiCombobox to Euisearchable

Signed-off-by: xyinshen <xyinshen@amazon.com>

* fix: update searchfiled with Euisearchable and update Euitext

Signed-off-by: xyinshen <xyinshen@amazon.com>

* fix: update searchfiled with Euisearchable and update Euitext

Signed-off-by: xyinshen <xyinshen@amazon.com>

* fix: fix conflict and update unit-test

Signed-off-by: xyinshen <xyinshen@amazon.com>

* fix: resolve conflict and update unit test

Signed-off-by: xyinshen <xyinshen@amazon.com>

* fix: restore an incorrect change

Signed-off-by: xyinshen <xyinshen@amazon.com>

* fix: update unit test error

Signed-off-by: xyinshen <xyinshen@amazon.com>

* fix: update to newest UI

Signed-off-by: xyinshen <xyinshen@amazon.com>

* fix: fix test_utils lint error

Signed-off-by: xyinshen <xyinshen@amazon.com>

* fix: add description and update code with review comment

Signed-off-by: xyinshen <xyinshen@amazon.com>

* fix: update code with newest code standards and update register form header descriptions

Signed-off-by: xyinshen <xyinshen@amazon.com>

* fix: update unit_test of register_model_type_modal

Signed-off-by: xyinshen <xyinshen@amazon.com>

* fix: remove test/test_utils.tsx change

Signed-off-by: xyinshen <xyinshen@amazon.com>

* fix: Let the modal dialog load the model list

Signed-off-by: xyinshen <xyinshen@amazon.com>

* fix: update register_modal unit-test

Signed-off-by: xyinshen <xyinshen@amazon.com>

* fix: delete customProps and use values in jsx

Signed-off-by: xyinshen <xyinshen@amazon.com>

* refactor: remove common/registry_modal_option.ts

Signed-off-by: xyinshen <xyinshen@amazon.com>

* fix: remove monitoring/model_status_filter.tsx change

Signed-off-by: xyinshen <xyinshen@amazon.com>

---------

Signed-off-by: xyinshen <xyinshen@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
* fix: update-register-form-hearder-descriptions

Signed-off-by: xyinshen <xyinshen@amazon.com>

* fix: restore unnecessary remove

Signed-off-by: xyinshen <xyinshen@amazon.com>

* fix: remove wrap with div and update code structure

Signed-off-by: xyinshen <xyinshen@amazon.com>

---------

Signed-off-by: xyinshen <xyinshen@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
+ display notification if file upload failed/succeed
+ add rxjs

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
+ increase model file size limit to 4GB
+ add model file extension validation to only allow ZIP file

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
…ct#126)

+ polling model upload task status and show notifications if task failed/successful
+ removed useModelUpload hook and refactor it with rxjs

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
* feat: validate model name after input blurred

Signed-off-by: Lin Wang <wonglam@amazon.com>

* refactor: remove model API mock and unified search API mock

Signed-off-by: Lin Wang <wonglam@amazon.com>

---------

Signed-off-by: Lin Wang <wonglam@amazon.com>
…t#133)

* feat: add version notes to register model form

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: remove annotation field

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: remove model details and update form header description

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: remove annotations field in ModelFormBase

Signed-off-by: Lin Wang <wonglam@amazon.com>

---------

Signed-off-by: Lin Wang <wonglam@amazon.com>
* feat: remove unused DIV wrapper

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: add model repository related API

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: add model repository manager

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: fetch model repository data in register_model_type_modal and register_model form

Signed-off-by: Lin Wang <wonglam@amazon.com>

* refactor: change switchMap to map

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: update to main branch pre-trained models URL

Signed-off-by: Lin Wang <wonglam@amazon.com>

---------

Signed-off-by: Lin Wang <wonglam@amazon.com>
There will be a separate task to refactor the rest pagination code to
the new one and then we can safely get rid of the legacy pagination
methods

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
+ Navigate to model group page after model creation succeed
+ Added a new route `/model-registry/model/:id` for model group

fixed a couple of issues due to conflicts of merging 2.x to feature/model-registry:
1. pagination refactor
2. removed unused convertModelSource

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
…ect#135)

* feat: clear observable object after error catched

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: update pre-trained model config data

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: fill pre-trained name description configuration in model import form

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: add loading screen for importing pre-trained model form

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: add todo for failed to load pre-trained model

Signed-off-by: Lin Wang <wonglam@amazon.com>

---------

Signed-off-by: Lin Wang <wonglam@amazon.com>
…project#130)

* fix: update-register-form-hearder-descriptions

Signed-off-by: xyinshen <xyinshen@amazon.com>

* fix: update File & version title

Signed-off-by: xyinshen <xyinshen@amazon.com>

* fix: update File & version title

Signed-off-by: xyinshen <xyinshen@amazon.com>

* fix: update configuration description

Signed-off-by: xyinshen <xyinshen@amazon.com>

* fix: using font-size displayed in figma

Signed-off-by: xyinshen <xyinshen@amazon.com>

* fix: update configuration unit-test

Signed-off-by: xyinshen <xyinshen@amazon.com>

* fix: remove eui-textInheritColor

Signed-off-by: xyinshen <xyinshen@amazon.com>

* fix: remove self-defined css

Signed-off-by: xyinshen <xyinshen@amazon.com>

* fix: add help button

Signed-off-by: xyinshen <xyinshen@amazon.com>

* fix: add help button unit-test

Signed-off-by: xyinshen <xyinshen@amazon.com>

* fix: remove unnecessary change

Signed-off-by: xyinshen <xyinshen@amazon.com>

* fix: restore empty line change

Signed-off-by: xyinshen <xyinshen@amazon.com>

* fix: restore empty line change

Signed-off-by: xyinshen <xyinshen@amazon.com>

* fix: restore unnecessary empty line

Signed-off-by: xyinshen <xyinshen@amazon.com>

---------

Signed-off-by: xyinshen <xyinshen@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
* fix: update-register-form-hearder-descriptions

Signed-off-by: xyinshen <xyinshen@amazon.com>

* fix: update File & version title

Signed-off-by: xyinshen <xyinshen@amazon.com>

* fix: update File & version title

Signed-off-by: xyinshen <xyinshen@amazon.com>

* fix: using font-size displayed in figma

Signed-off-by: xyinshen <xyinshen@amazon.com>

* fix: remove self-defined css

Signed-off-by: xyinshen <xyinshen@amazon.com>

* fix: add help button

Signed-off-by: xyinshen <xyinshen@amazon.com>

* fix: add help button unit-test

Signed-off-by: xyinshen <xyinshen@amazon.com>

* fix: remove unnecessary change

Signed-off-by: xyinshen <xyinshen@amazon.com>

* fix: restore unnecessary empty line

Signed-off-by: xyinshen <xyinshen@amazon.com>

* fix: update form_partial_description_max-width-to-725px

Signed-off-by: xyinshen <xyinshen@amazon.com>

* fix: fix test_error

Signed-off-by: xyinshen <xyinshen@amazon.com>

---------

Signed-off-by: xyinshen <xyinshen@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
…ject#138)

The rule is applied to:
1. Model name input
2. Model description input
3. Model note input

+ removed validation rules on name, description and note input
+ renamed isUniqueModelName to isDuplicateModelName

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
* refactor: use mode to finish different register form setup

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: update tag logic and UI according the new design

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: remove metric input

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: update tags panel order for register own model

Signed-off-by: Lin Wang <wonglam@amazon.com>

* refactor: change to use setup init register form

Signed-off-by: Lin Wang <wonglam@amazon.com>

* test: add case for hidden selected item in option list

Signed-off-by: Lin Wang <wonglam@amazon.com>

* fix: add back selected value in value option list

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: update validate to avoid duplicate tag keys

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: update tags panel description for register new version

Signed-off-by: Lin Wang <wonglam@amazon.com>

* test: correct error message in register model setup

Signed-off-by: Lin Wang <wonglam@amazon.com>

* chore: update the annotation for duplicate tag key

Signed-off-by: Lin Wang <wonglam@amazon.com>

---------

Signed-off-by: Lin Wang <wonglam@amazon.com>
wanglam and others added 30 commits December 25, 2024 17:42
…ct#176)

* feat: change to use tab id store selected tab

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: display - for empty description

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: add bottom form action bar

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: add name and description in details panel

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: separate ModelNameField, ModelDescriptionField and ErrorCallOut to common folder

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: add readonly and originalModelname to ModelNameField

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: add readonly to ModelDescriptionField

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: update error call out according new design

Signed-off-by: Lin Wang <wonglam@amazon.com>

* test: update model_handlers error field and name search

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: change to use model name description field in common folder

Signed-off-by: Lin Wang <wonglam@amazon.com>

---------

Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
* feat: separate tag_key render and types

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: add model detail tags panel content

Signed-off-by: Lin Wang <wonglam@amazon.com>

* fix: new added tag input not aligned

Signed-off-by: Lin Wang <wonglam@amazon.com>

* refactor: use dirtyFields.tagKeys length directly

Signed-off-by: Lin Wang <wonglam@amazon.com>

* refactor: disable saved tag key by name

Signed-off-by: Lin Wang <wonglam@amazon.com>

---------

Signed-off-by: Lin Wang <wonglam@amazon.com>
On model version page, a new version tag edit panel is add to allow user
to manage tags of a model version

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
feat: edit model artifact and configuration on version details page

Enable user to edit model version artifact and configuration

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
…ject#185)

* feat: add loading, empty, failed and no result screen for model detail version table

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: add versionOrKeyword parameter for model search

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: add search logic to model detail version table

Signed-off-by: Lin Wang <wonglam@amazon.com>

* refactor: update lastUpdated to lastUpdatedTime in model detail version table

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: add last_registered_time, last_deployed_time and last_undeployed_time to model detail version status cell

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: only show 3 tag columns by default

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: change to use dateFormat in ui settings

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: hide time title for in progress version

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: add sort to model detail version table

Signed-off-by: Lin Wang <wonglam@amazon.com>

* test: increase timeout to fix test case error in github runner

Signed-off-by: Lin Wang <wonglam@amazon.com>

* test: change to wait for version header exists

Signed-off-by: Lin Wang <wonglam@amazon.com>

* chore: address PR comments

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: add UiSettingDateFormatTime

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: change to use UiSettingDateFormatTime

Signed-off-by: Lin Wang <wonglam@amazon.com>

* fix: model search sort validate with sort pair

Signed-off-by: Lin Wang <wonglam@amazon.com>

---------

Signed-off-by: Lin Wang <wonglam@amazon.com>
* feat: move ModelVersionErrorDetailsModal to common folder

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: add undeployment-failed mode and plainVersionLink

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: add model version deployment confirm modal

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: add deploy confirm modal in model version table row actions

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: address PR comments

Signed-off-by: Lin Wang <wonglam@amazon.com>

* refactor: update mode to errorType

Signed-off-by: Lin Wang <wonglam@amazon.com>

* test: increase model version panel test timeout

Signed-off-by: Lin Wang <wonglam@amazon.com>

---------

Signed-off-by: Lin Wang <wonglam@amazon.com>
* feat: add model group related API

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: call model group register and delete when model register

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: check name unique from model group search

Signed-off-by: Lin Wang <wonglam@amazon.com>

* fix: register model group call in register model version

Signed-off-by: Lin Wang <wonglam@amazon.com>

* fix: model delete after model version register failed

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: add model access control related fields for create model group API

Signed-off-by: Lin Wang <wonglam@amazon.com>

---------

Signed-off-by: Lin Wang <wonglam@amazon.com>
* feat: mock EuiDataGrid to speedup case running

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: add modelGroupId to model search

Signed-off-by: Lin Wang <wonglam@amazon.com>

* test: support modelGroupId search mock

Signed-off-by: Lin Wang <wonglam@amazon.com>

* test: mock EuiDataGrid to speedup model test

Signed-off-by: Lin Wang <wonglam@amazon.com>

* fix: redirect to model page with correct model id

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: update to use created_time

Signed-off-by: Lin Wang <wonglam@amazon.com>

---------

Signed-off-by: Lin Wang <wonglam@amazon.com>
* feat: update model aggregate service according new design

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: add link to the model version page

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: remove model to model version and remove legacy opensearch client usage

Signed-off-by: Lin Wang <wonglam@amazon.com>

* refactor: update MODEL_STATE to MODEL_VERSION_STATE

Signed-off-by: Lin Wang <wonglam@amazon.com>

* update model-version API endpoint address

Signed-off-by: Lin Wang <wonglam@amazon.com>

* refactor: rename model group to model

Signed-off-by: Lin Wang <wonglam@amazon.com>

* refactor: replace queryString with extraQuery

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: rename modelId to id in model version

Signed-off-by: Lin Wang <wonglam@amazon.com>

* fix: model group id not exists in model register API

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: update GET to POST for model search

Signed-off-by: Lin Wang <wonglam@amazon.com>

---------

Signed-off-by: Lin Wang <wonglam@amazon.com>
On version details page, now user can deploy/undeploy the current model by click a button

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
* test: separate mockOpenSearchDashboards

Signed-off-by: Lin Wang <wonglam@amazon.com>

* fix: update id to modelId in model version upload API

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: add model version delete confirm and unable do action modal

Signed-off-by: Lin Wang <wonglam@amazon.com>

* refactor: refactor delete polling with rxjs

Signed-off-by: Lin Wang <wonglam@amazon.com>

* fix: update model id and owner

Signed-off-by: Lin Wang <wonglam@amazon.com>

* fix: request should wait previous response

Signed-off-by: Lin Wang <wonglam@amazon.com>

---------

Signed-off-by: Lin Wang <wonglam@amazon.com>
feat: import pre-trained model by name

+ update description field to optional fix type error

---------

Signed-off-by: Lin Wang <wonglam@amazon.com>
feat: add model delete confirm modal

---------

Signed-off-by: Lin Wang <wonglam@amazon.com>
…pensearch-project#216)

* feat: refresh model version data after deploy or undeploy complete

Signed-off-by: Lin Wang <wonglam@amazon.com>

* fix: undeploy no onComplete and onError

Signed-off-by: Lin Wang <wonglam@amazon.com>

---------

Signed-off-by: Lin Wang <wonglam@amazon.com>
…pensearch-project#220)

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants