[LuceneOnFaiss - Part2] Added IxMp section loading logic from FAISS index. #2590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0ctopus13prime
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan,
luyuncheng,
shatejas and
Vikasht34
as code owners
0ctopus13prime
force-pushed
the
lucene-on-faiss-part2
branch
from
4a8944f to
b60e5d1
Compare
|
Will continuously add unit tests to this PR. |
0ctopus13prime
changed the title
0ctopus13prime
force-pushed
the
lucene-on-faiss-part2
branch
from
b60e5d1 to
b6bdf7e
Compare
shatejas
reviewed
Mar 10, 2025
src/main/java/org/opensearch/knn/memoryoptsearch/faiss/FaissIdMapIndex.java
Show resolved
Hide resolved
src/main/java/org/opensearch/knn/memoryoptsearch/faiss/FaissIdMapIndex.java
Outdated
Show resolved
Hide resolved
shatejas
reviewed
Mar 10, 2025
src/main/java/org/opensearch/knn/index/codec/KNN990Codec/NativeEngines990KnnVectorsReader.java
Show resolved
Hide resolved
0ctopus13prime
force-pushed
the
lucene-on-faiss-part2
branch
2 times, most recently
from
4995e37 to
4726205
Compare
shatejas
reviewed
Mar 10, 2025
src/main/java/org/opensearch/knn/memoryoptsearch/faiss/FaissIdMapIndex.java
Outdated
Show resolved
Hide resolved
jmazanec15
reviewed
Mar 10, 2025
src/main/java/org/opensearch/knn/memoryoptsearch/faiss/FaissIdMapIndex.java
Show resolved
Hide resolved
src/main/java/org/opensearch/knn/memoryoptsearch/faiss/FaissIdMapIndex.java
Show resolved
Hide resolved
src/main/java/org/opensearch/knn/memoryoptsearch/faiss/IndexTypeToFaissIndexMapping.java
Show resolved
Hide resolved
Signed-off-by: Dooyong Kim <kdooyong@amazon.com>
0ctopus13prime
force-pushed
the
lucene-on-faiss-part2
branch
from
4726205 to
0d2170e
Compare
shatejas
approved these changes
Mar 11, 2025
0ctopus13prime
merged commit 4e80b65
into
opensearch-project:lucene-on-faiss
34 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[2/11] This PR adds a loading logic of FaissIdMapIndex section in FAISS section.
This section contains a mapping table to maps an internal vector id to external Lucene document id.
There are two cases
Related Issues
RFC : #2401
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.