Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync benchmark folder from main #1497

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Conversation

heemin32
Copy link
Collaborator

Description

The benchmark folder in 2.x branch is drifted a lot from main branch. Replaced the entire benchmark folder with the one from main branch

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Heemin Kim <heemin@amazon.com>
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.09%. Comparing base (6be0f0c) to head (30bb554).

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x    #1497      +/-   ##
============================================
- Coverage     85.11%   85.09%   -0.02%     
+ Complexity     1256     1255       -1     
============================================
  Files           162      162              
  Lines          5152     5152              
  Branches        495      495              
============================================
- Hits           4385     4384       -1     
  Misses          560      560              
- Partials        207      208       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martin-gaievski
Copy link
Member

How did you test that there are no missing pieces, can you please share results here?

@heemin32
Copy link
Collaborator Author

heemin32 commented Feb 23, 2024

How did you test that there are no missing pieces, can you please share results here?

I just removed the folder from 2.x branch and copied the entire folder from main. I don't think there is any different between main and 2.x for benchmark test code. Therefore, if it works for main, it should work for 2.x

@martin-gaievski
Copy link
Member

How did you test that there are no missing pieces, can you please share results here?

I just removed the folder from 2.x branch and copied the entire folder from main. I don't think there is any different between main and 2.x for benchmark test code. Therefore, if it works for main, it should work for 2.x

I see, we can probably fix errors if any when that is executed for a benchmark of some feature or for next release, I think that's fine.

@heemin32
Copy link
Collaborator Author

How did you test that there are no missing pieces, can you please share results here?

I just removed the folder from 2.x branch and copied the entire folder from main. I don't think there is any different between main and 2.x for benchmark test code. Therefore, if it works for main, it should work for 2.x

I see, we can probably fix errors if any when that is executed for a benchmark of some feature or for next release, I think that's fine.

Actually, we only use benchmark tool from main branch. That is why people forget to backport benchmark related PR to 2.x.

@heemin32 heemin32 merged commit 1d08467 into opensearch-project:2.x Feb 23, 2024
83 of 86 checks passed
@heemin32 heemin32 deleted the bench-2.x branch February 23, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants