Use valid data for sqfp16 test #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Heemin Kim <heemin@amazon.com>
heemin32
requested review from
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski and
ryanbogan
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1474 +/- ##
=========================================
Coverage 85.02% 85.02%
Complexity 1277 1277
=========================================
Files 167 167
Lines 5207 5207
Branches 493 493
=========================================
Hits 4427 4427
Misses 572 572
Partials 208 208 ☔ View full report in Codecov by Sentry. |
|
@heemin32 Thanks for adding this. |
naveentatikonda
approved these changes
Feb 9, 2024
junqiu-lei
approved these changes
Feb 9, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 9, 2024
Signed-off-by: Heemin Kim <heemin@amazon.com> (cherry picked from commit e2d5bc5)
heemin32
added a commit
that referenced
this pull request
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current sqfp16 tests uses vector value outside of fp16 range which result in infinite value during faiss distance calculation. Because of this infinite distance, the search result is not returned once we update faiss commit number with 32f0e8cf92cd2275b60364517bb1cce67aa29a55.
This fix the test so that vector value to be in fp16 range.
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.