Disable warning checks in k-NN test case #1442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junqiu-lei
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
martin-gaievski and
ryanbogan
as code owners
junqiu-lei
force-pushed
the
flaky-Flaky-KNNSettingsTests
branch
from
987e4e8 to
a727042
Compare
heemin32
reviewed
Feb 1, 2024
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
junqiu-lei
force-pushed
the
flaky-Flaky-KNNSettingsTests
branch
from
a727042 to
6c65686
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1442 +/- ##
============================================
- Coverage 85.07% 85.05% -0.02%
- Complexity 1278 1279 +1
============================================
Files 167 167
Lines 5207 5207
Branches 493 493
============================================
- Hits 4430 4429 -1
- Misses 570 572 +2
+ Partials 207 206 -1 ☔ View full report in Codecov by Sentry. |
junqiu-lei
changed the title
jmazanec15
reviewed
Feb 7, 2024
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
jmazanec15
previously approved these changes
Feb 7, 2024
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
heemin32
approved these changes
Feb 8, 2024
jmazanec15
approved these changes
Feb 8, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 8, 2024
* Disable warning checks in k-NN test case Signed-off-by: Junqiu Lei <junqiu@amazon.com> (cherry picked from commit 9e28957)
junqiu-lei
added a commit
that referenced
this pull request
Feb 8, 2024
heemin32
pushed a commit
that referenced
this pull request
Feb 8, 2024
* Disable warning checks in k-NN test case Signed-off-by: Junqiu Lei <junqiu@amazon.com> (cherry picked from commit 9e28957) Co-authored-by: Junqiu Lei <junqiu@amazon.com> (cherry picked from commit 29279dc) Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR followed from #1392 (comment) to disable warnings check in k-NN tests case and remove warning Assertions in KNNSettingsTests
Issues Resolved
#1392, #1391, #1390, #1389
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.