Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing create index and use case input parsing bugs #600

Merged
merged 4 commits into from
Mar 20, 2024

addressed comments and cleaned up defaults/templates

cad55fa
Select commit
Loading
Failed to load commit list.
Merged

Fixing create index and use case input parsing bugs #600

addressed comments and cleaned up defaults/templates
cad55fa
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 20, 2024 in 1s

72.54% (-0.22%) compared to 149e22a

View this Pull Request on Codecov

72.54% (-0.22%) compared to 149e22a

Details

Codecov Report

Attention: Patch coverage is 59.52381% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 72.54%. Comparing base (149e22a) to head (cad55fa).

Files Patch % Lines
...search/flowframework/workflow/CreateIndexStep.java 50.00% 6 Missing and 3 partials ⚠️
.../org/opensearch/flowframework/util/ParseUtils.java 56.25% 6 Missing and 1 partial ⚠️
...h/flowframework/rest/RestCreateWorkflowAction.java 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x     #600      +/-   ##
============================================
- Coverage     72.75%   72.54%   -0.22%     
- Complexity      681      684       +3     
============================================
  Files            82       82              
  Lines          3491     3526      +35     
  Branches        279      285       +6     
============================================
+ Hits           2540     2558      +18     
- Misses          832      845      +13     
- Partials        119      123       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.