Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add markers for cluster APIs. #9110
base: main
Are you sure you want to change the base?
Add markers for cluster APIs. #9110
Changes from all commits
8234ec2
9ac0957
7f0f39b
44d9145
94b4cd1
eff3c78
645f9e1
b713b3b
bab9e3c
5607382
5f60253
7550e90
5fbb2c4
19b60e4
ecdce80
7c8ea81
662c507
403e330
999aef7
9ea5bc7
93cfb7b
96a153f
437d733
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there is a path parameter
attribute
. Please include thepath parameters
section.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this list auto-generated? If so, we should change the generator to use commas instead of semicolons between list elements. cc: @nhtruong
Also, can we link to the cluster update settings API?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me check is the list is autogenerated, considering the list's placement in the description, I'm assuming no.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Several comments on
cluster_manager_timeout
:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Time unit" is not a supported data type, according to the list of supported Data Types for OpenAPI. https://swagger.io/docs/specification/v3_0/data-models/data-types/
Not sure if there's a way to change the Data type manually beyond editing the table directly. That being said, I wouldn't advise it, since "String" matches what's in the API spec.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as
cluster_manager_timeout
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The old descriptions for both of these parameters were more descriptive. Could we propagate them to the api-spec repo?