Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

version definition is no longer used by Docker Compose #8821

Merged
merged 2 commits into from
Feb 18, 2025
Merged

version definition is no longer used by Docker Compose #8821

merged 2 commits into from
Feb 18, 2025
+0 −4

Conversation

epugh
Copy link
Collaborator

@epugh epugh commented Nov 26, 2024

Description

Remove the version from the docker-compose.yml files, it actually now generates a warning!

Issues Resolved

n/a

Version

n/a

Frontend features

n/a

Checklist

  • [ x] By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@epugh
version is no longer used by Docker Compose
3036b17 
Signed-off-by: Eric Pugh <epugh@opensourceconnections.com>
@github-actions GitHub Actions
Copy link

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

@kolchfa-aws
Copy link
Collaborator

@epugh There is a related PR #8606 that we're waiting to merge until this change is applied in all pertinent places. See this comment for details #8606 (comment)

@epugh epugh mentioned this pull request Feb 17, 2025
Merged
1 task
@kolchfa-aws
Copy link
Collaborator

@epugh #8606 is merged: do you want to close this PR?

@epugh
Copy link
Collaborator Author

epugh commented Feb 17, 2025

I believe that this PR is actually updating different docker-compose.yml files than the one in #8606 does... So this still is valid.

kolchfa-aws
kolchfa-aws approved these changes Feb 18, 2025
View reviewed changes
Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kolchfa-aws kolchfa-aws merged commit c0b50c1 into opensearch-project:main Feb 18, 2025
6 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 18, 2025
@github-actions @kolchfa-aws
version is no longer used by Docker Compose (#8821)
c2a286b 
Signed-off-by: Eric Pugh <epugh@opensourceconnections.com>
Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
(cherry picked from commit c0b50c1)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Feb 18, 2025
Merged
@kolchfa-aws kolchfa-aws mentioned this pull request Feb 18, 2025
Closed
github-actions bot pushed a commit that referenced this pull request Feb 18, 2025
@opensearch-trigger-bot
version is no longer used by Docker Compose (#8821) (#9236)
061d50a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolchfa-aws kolchfa-aws kolchfa-aws approved these changes

@Naarcha-AWS Naarcha-AWS Awaiting requested review from Naarcha-AWS Naarcha-AWS is a code owner

@vagimeli vagimeli Awaiting requested review from vagimeli

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@natebower natebower Awaiting requested review from natebower natebower is a code owner

@dlvenable dlvenable Awaiting requested review from dlvenable dlvenable is a code owner

Assignees

@kolchfa-aws kolchfa-aws

Labels
backport 2.19
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@epugh @kolchfa-aws