-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the documentation of create or update alias API #7641
Conversation
Signed-off-by: gaobinlong <gbinlong@amazon.com>
Signed-off-by: gaobinlong <gbinlong@amazon.com>
@Naarcha-AWS Thanks for your review, I've modified the documentation yet, thank you! |
@gaobinlong: I took another glance at the Index APIs and discovered we already have a page on aliases. https://opensearch.org/docs/latest/api-reference/index-apis/alias/ Do you want to add your changes on top of that page? |
They are different APIs, actually there's some ambiguity between them, so this PR aims to eliminate the ambiguity. |
@gaobinlong: Can you clarify the ambiguities? |
Does the |
|
Signed-off-by: gaobinlong <gbinlong@amazon.com>
@Naarcha-AWS I've added some clarification in this document, please help to take a look, thank you! |
Thanks @gaobinlong! I adjusted the format slightly. I'll go ahead and pass this into editorial review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gaobinlong @Naarcha-AWS Please see my comments and changes and tag me on lines 16 and 21 for approval when complete. Thanks!
@@ -0,0 +1,85 @@ | |||
--- | |||
layout: default | |||
title: Create or update alias |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be in title case if it's the name of the API?
nav_order: 5 | ||
--- | ||
|
||
# Create or update alias |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same
|
||
## Path and HTTP methods | ||
|
||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
json?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not for these. They are meant to be copy and pasted individually depending on what endpoint the user selects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Naarcha-AWS Based on the API template, shouldn't this have highlighting, though? @kolchfa-aws Can you verify?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, even though the path and HTTP method are not part of JSON, we still have the json formatting tag on these for consistency.
Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
Signed-off-by: Nathan Bower <nbower@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Add the documentation of create or update alias API Signed-off-by: gaobinlong <gbinlong@amazon.com> * Fix typo Signed-off-by: gaobinlong <gbinlong@amazon.com> * Refine the wording Signed-off-by: gaobinlong <gbinlong@amazon.com> * Update update-alias.md * Fix typo Signed-off-by: gaobinlong <gbinlong@amazon.com> * Add some clarification Signed-off-by: gaobinlong <gbinlong@amazon.com> * Update update-alias.md * Update update-alias.md * Apply suggestions from code review Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> * Update _api-reference/index-apis/update-alias.md Signed-off-by: Nathan Bower <nbower@amazon.com> --------- Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Nathan Bower <nbower@amazon.com> Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Co-authored-by: Nathan Bower <nbower@amazon.com> (cherry picked from commit 06ef161) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ct#7641) * Add the documentation of create or update alias API Signed-off-by: gaobinlong <gbinlong@amazon.com> * Fix typo Signed-off-by: gaobinlong <gbinlong@amazon.com> * Refine the wording Signed-off-by: gaobinlong <gbinlong@amazon.com> * Update update-alias.md * Fix typo Signed-off-by: gaobinlong <gbinlong@amazon.com> * Add some clarification Signed-off-by: gaobinlong <gbinlong@amazon.com> * Update update-alias.md * Update update-alias.md * Apply suggestions from code review Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> * Update _api-reference/index-apis/update-alias.md Signed-off-by: Nathan Bower <nbower@amazon.com> --------- Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Nathan Bower <nbower@amazon.com> Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com>
…ct#7641) * Add the documentation of create or update alias API Signed-off-by: gaobinlong <gbinlong@amazon.com> * Fix typo Signed-off-by: gaobinlong <gbinlong@amazon.com> * Refine the wording Signed-off-by: gaobinlong <gbinlong@amazon.com> * Update update-alias.md * Fix typo Signed-off-by: gaobinlong <gbinlong@amazon.com> * Add some clarification Signed-off-by: gaobinlong <gbinlong@amazon.com> * Update update-alias.md * Update update-alias.md * Apply suggestions from code review Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> * Update _api-reference/index-apis/update-alias.md Signed-off-by: Nathan Bower <nbower@amazon.com> --------- Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Nathan Bower <nbower@amazon.com> Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Sander van de Geijn <sandervandegeijn@icloud.com>
Description
Document the usage of the create or update alias API, which was introduced in 1.0.
Issues Resolved
Closes #7640
Version
All versions.
Frontend features
If you're submitting documentation for an OpenSearch Dashboards feature, add a video that shows how a user will interact with the UI step by step. A voiceover is optional.
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.