Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Change dompurify version to 3.0.11 to match OSD #520

Merged
merged 1 commit into from
Feb 22, 2025
Merged

[Backport 2.x] Change dompurify version to 3.0.11 to match OSD #520

merged 1 commit into from
Feb 22, 2025

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 9fa0467 from #516.

@github-actions
change dompurify version to ^3.0.11 to match osd (#516)
c2bf633 
Signed-off-by: Ritvi Bhatt <ribhatt@amazon.com>
Co-authored-by: Ritvi Bhatt <ribhatt@amazon.com>
(cherry picked from commit 9fa0467)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshuali925
joshuali925 approved these changes Feb 22, 2025
View reviewed changes
Copy link
Member

@joshuali925 joshuali925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can drop dompurify dependency from here and use the core one. and we don't need to backport 2.x i think, unless there will be 2.20 cut

@ps48
Copy link
Member

ps48 commented Feb 22, 2025

we can drop dompurify dependency from here and use the core one. and we don't need to backport 2.x i think, unless there will be 2.20 cut

ack removing it in the new PR: #529

@ps48 ps48 merged commit 0ae67b0 into 2.x Feb 22, 2025
12 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ps48 ps48 ps48 approved these changes

@joshuali925 joshuali925 joshuali925 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ps48 @joshuali925