[Bug] Traces redirection while QA enabled #2369
Conversation
Signed-off-by: Adam Tackett <tackadam@amazon.com>
Not that I can tell, as soon as a question is prompted it switched the source to the selected index and overrides what is present from the re-direction. |
| @@ -259,7 +259,6 @@ export const Search = (props: any) => { | |||
| setSelectedIndex(reduxIndex); | |||
| // sets the editor text and populates sidebar field for a particular index upon initialization | |||
| const indexQuery = `source = ${reduxIndex[0].label}`; | |||
| handleQueryChange(indexQuery); | |||
There was a problem hiding this comment.
If I'm remembering correctly, this method was used to set the query inside of the "query area" from a redirection related to query assistant. Did we know what this was used for beforehand and if it remains unaffected with this change?
One of these redirections I believe were from the welcome page with sample indices and sample natural language queries, could start with testing that interaction.
There was a problem hiding this comment.
@paulstn Do you know was it some custom welcome page or released in a particular OS version? We are not able to find this on our side..
There was a problem hiding this comment.
Tested the 2.13 new home page setting which just provides links to documentation, no workflow identified that landed on the explorer page with an example query.
There was a problem hiding this comment.
Regardless of being able to find the welcome page, the purpose of this line was to populate the query area with some placeholder text. If we're fine removing that placeholder then there isn't an issue.
Signed-off-by: Adam Tackett <tackadam@amazon.com> Co-authored-by: Adam Tackett <tackadam@amazon.com> (cherry picked from commit 8adb81e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 8adb81e) Signed-off-by: Adam Tackett <tackadam@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Adam Tackett <tackadam@amazon.com>
Description
Re-direction from Traces to Explorer to view logs is being over written when QA is enabled.
Before:
BeforeChange.mov
After:
AfterChange.mov
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.