[2.x] Backport query assist #1369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ature/explorer-query-assistant Merge feature/explorer-query-assistant to main (cherry picked from commit 38957cd)
Signed-off-by: Joshua Li <joshuali925@gmail.com> (cherry picked from commit 7b4d148)
* turned 40 year defaults into dependent on query assistant Signed-off-by: Paul Sebastian <paulstn@amazon.com> * fix search test, undefined handling Signed-off-by: Paul Sebastian <paulstn@amazon.com> * include some constants for specific time choices Signed-off-by: Paul Sebastian <paulstn@amazon.com> * changed naming of some constants Signed-off-by: Paul Sebastian <paulstn@amazon.com> * fix search test Signed-off-by: Paul Sebastian <paulstn@amazon.com> * change back query slice Signed-off-by: Paul Sebastian <paulstn@amazon.com> * failing snapshot updated after merge with main Signed-off-by: Paul Sebastian <paulstn@amazon.com> --------- Signed-off-by: Paul Sebastian <paulstn@amazon.com> (cherry picked from commit d741ed4)
joshuali925
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsimanohar,
Swiddis,
penghuo,
seankao-az and
anirudha
as code owners
ps48
reviewed
Jan 18, 2024
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com> (cherry picked from commit a5824bd)
|
Thanks for taking this on @joshuali925. LGTM, and just a tiny linting error need to be fixed: https://github.com/opensearch-project/dashboards-observability/actions/runs/7588601129/job/20671492177?pr=1369#step:10:95 |
RyanL1997
approved these changes
Jan 19, 2024
Signed-off-by: Joshua Li <joshuali925@gmail.com> (cherry picked from commit 4cfd171)
|
@RyanL1997 i just realized that current lint workflow will fail if one file failed to lint, it gets tedious if there are multiple failed files since it requires multiple runs i sent a PR to fix it #1378 |
6 tasks
Swiddis
approved these changes
Jan 23, 2024
paulstn
approved these changes
Jan 23, 2024
Signed-off-by: Joshua Li <joshuali925@gmail.com> (cherry picked from commit f2dcae4)
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
Signed-off-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: Paul Sebastian <paulstn@amazon.com> (cherry picked from commit d4d8dbc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
backports #1325, #1359, #1360, #1376, #1379
cc @paulstn i picked the 3 commits for query assist to 2.x, if you have other fixes for it please let me know or update this PR
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.