Cache form across ML transform types #678
Merged
+108
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
ohltyler
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
amitgalitz,
jackiehanyang,
minalsha and
saimedhi
as code owners
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
ohltyler
changed the title
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
saimedhi
approved these changes
Mar 19, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 19, 2025
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> (cherry picked from commit b1f240c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ohltyler
pushed a commit
that referenced
this pull request
Mar 19, 2025
(cherry picked from commit b1f240c) Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds caches for the input/output forms for ML processors, such that values are cached across different transform types. The idea is users can easily toggle between types and not lose lost configuration. Note this is only cached while the component is loaded on the page; a navigation away or page refresh will lose the cached state.
Implementation-wise, this adds a util fn shared across
model_inputsandmodel_outputsto update a cache, and pre-populate values from the cache, as users change underlying transform types within the input/output maps.Demo video:
screen-capture.30.webm
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.